From: Tom Lane <tgl@sss.pgh.pa.us>
To: jazz001319@gmail.com
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17886: Error disabling user triggers on a partitioned table
Date: Tue, 04 Apr 2023 14:24:32 -0400
Message-ID: <1582614.1680632672@sss.pgh.pa.us> (raw)
In-Reply-To: <17886-5406d5d828aa4aa3@postgresql.org>
References: <17886-5406d5d828aa4aa3@postgresql.org>
PG Bug reporting form <noreply@postgresql.org> writes:
> result:
> postgres=# alter table public.test DISABLE TRIGGER USER;
> ERROR: 42704: trigger "trigger_test" for table "test_def" does not exist
> LOCATION: EnableDisableTriggerNew, trigger.c:1658
> Expected Result (Postgresql 15.2 and 14.4 - fine):
> testdb=> alter table public.test DISABLE TRIGGER USER;
> ALTER TABLE
Commit ec0925c22 seems to have been quite snakebit. I already fixed
a deficiency in it in v15/HEAD, but here we have a different symptom
in the older branches. What's happening is that EnableDisableTrigger
is ignoring the child trigger because it has tgisinternal set to true
and the command passes skip_system = true.
I'm inclined to think that in the older branches (pre f4566345c)
we need to do
- if (oldtrig->tgisinternal)
+ if (oldtrig->tgisinternal && !OidIsValid(oldtrig->tgparentid))
{
/* system trigger ... ok to process? */
but I've not tested that. Alvaro, what do you think?
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, jazz001319@gmail.com, alvherre@alvh.no-ip.org, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17886: Error disabling user triggers on a partitioned table
In-Reply-To: <1582614.1680632672@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox