pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Zsolt Ero <zsolt.ero@gmail.com>
Cc: Magnus Hagander <magnus@hagander.net>
Cc: PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Cc: Daniel Gustafsson <daniel@yesql.se>
Subject: Re: BUG #16604: pg_dump with --jobs breaks SSL connections
Date: Thu, 24 Sep 2020 13:42:25 -0400
Message-ID: <1664516.1600969345@sss.pgh.pa.us> (raw)
In-Reply-To: <1663666.1600968283@sss.pgh.pa.us>
References: <16604-933f4b8791227b15@postgresql.org>
	<61B1FFD2-EA7B-4C62-92A1-44C5459189C0@yesql.se>
	<CABUevEwwr=oCNQnu2RUTLhKwyKxRh3C__ckum=Xgm+acgUEJ_Q@mail.gmail.com>
	<CAKw-smBKagNkWRZvTujeKgx6j5ZkjazDvDPFq9bZWbBC7YXqbg@mail.gmail.com>
	<1638874.1600963896@sss.pgh.pa.us>
	<1663666.1600968283@sss.pgh.pa.us>

I wrote:
> Note, however, that AFAICS parallel pg_restore was okay on duplicating
> the original connection parameters otherwise (the prompting issue
> was because it went too far with that...).  So I fail to confirm
> the OP's claim that pg_restore had the same bug as parallel pg_dump.
> If there really is an issue there, we'll need a test case that
> demonstrates it.

Hmm ... so a bit later, I have a test case that may or may not be
what Zsolt saw:

pg_restore -C --dbname="hostaddr=127.0.0.1 sslmode=verify-ca dbname=postgres user=postgres sslcert=client-cert.crt sslkey=client-cert.key" -Fd  dumpdir
pg_restore: error: could not reconnect to database: FATAL:  connection requires a valid client certificate

What is happening here is the exact same issue, but in
ReconnectToServer/_connectDB: those functions suppose that they
can blow away all the original connection parameters and insert
just a database name instead.  I'm inclined to think that
we should get rid of _connectDB, because it seems unnecessarily
duplicative with ConnectDatabase.  But we'll need a bit more
API refactoring than what I had.  New patch coming ...

			regards, tom lane





view thread (9+ messages)  latest in thread

Message-ID: <1664516.1600969345@sss.pgh.pa.us>
Permalink:  ../1664516.1600969345@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/1664516.1600969345@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, zsolt.ero@gmail.com, magnus@hagander.net, pgsql-bugs@lists.postgresql.org, daniel@yesql.se
  Subject: Re: BUG #16604: pg_dump with --jobs breaks SSL connections
  In-Reply-To: <1664516.1600969345@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox