From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Daniel Gustafsson <daniel@yesql.se>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: byavuz81@gmail.com, PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Cc: Heikki Linnakangas <heikki.linnakangas@iki.fi>
Cc: Michael Paquier <michael@paquier.xyz>
Subject: Re: BUG #17391: While using --with-ssl=openssl and PG_TEST_EXTRA='ssl' options, SSL tests fail on OpenBSD 7.0
Date: Thu, 10 Feb 2022 20:25:28 -0500
Message-ID: <1955929.1644542728@sss.pgh.pa.us> (raw)
In-Reply-To: <20220211011025.ek7exh6owpzjyudn@alap3.anarazel.de>
References: <131329.1643851912@sss.pgh.pa.us>
<203742.1643866877@sss.pgh.pa.us>
<C44CE9FB-B37E-47D3-924B-4AF808AE98B1@yesql.se>
<887CBA28-0942-4084-BE09-FBE0D6A1DB53@yesql.se>
<621771.1644098845@sss.pgh.pa.us>
<635760.1644108785@sss.pgh.pa.us>
<1113966.1644280235@sss.pgh.pa.us>
<C112C400-2CB5-4DCA-A699-00DC0333B665@yesql.se>
<1537890.1644462214@sss.pgh.pa.us>
<1952254.1644540297@sss.pgh.pa.us>
<20220211011025.ek7exh6owpzjyudn@alap3.anarazel.de>
Andres Freund <andres@anarazel.de> writes:
> It's not in this change, but related. I don't really understand the
> /*
> * PQgetResult will return immediately in all states except BUSY, or if we
> * had a write failure.
> */
> return conn->asyncStatus == PGASYNC_BUSY || conn->write_failed;
> business in PQisBusy(). Won't that potentially lead to clients waiting for
> more network IO indefinitely, never getting around to calling PQgetResult()?
I was staring at that for awhile too. It's my own code (from 1f39a1c0641)
but it sure confuses me now; at the very least the code is not in sync
with the comment. However, it's been that way for a couple years now and
we've not had complaints suggesting it's broken, so maybe it's the comment
that's wrong.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, daniel@yesql.se, thomas.munro@gmail.com, pgsql-bugs@lists.postgresql.org, heikki.linnakangas@iki.fi, michael@paquier.xyz
Subject: Re: BUG #17391: While using --with-ssl=openssl and PG_TEST_EXTRA='ssl' options, SSL tests fail on OpenBSD 7.0
In-Reply-To: <1955929.1644542728@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox