public inbox for [email protected]
help / color / mirror / Atom feedFrom: Vishal Prasanna <[email protected]>
To: Hayato Kuroda (Fujitsu) <[email protected]>
Cc: "'Álvaro Herrera'" <[email protected]>
Cc: pgsql-bugs <[email protected]>
Subject: RE: [BUG] Assert failure in ReorderBufferReturnTXN during logical decoding due to leaked specinsert change
Date: Thu, 26 Feb 2026 11:34:02 +0530
Message-ID: <[email protected]> (raw)
In-Reply-To: <OS9PR01MB12149FD6C66A344831EBD836EF572A@OS9PR01MB12149.jpnprd01.prod.outlook.com>
References: <[email protected]>
<[email protected]>
<OS9PR01MB12149FD6C66A344831EBD836EF572A@OS9PR01MB12149.jpnprd01.prod.outlook.com>
Dear Hayato, Álvaro,
>> Please don't do this. Changing the argument list of an exported
>> function is an ABI break. That's an OK change to do in branch master
>> (to keep the interface clean), but for released branches it is not
>> welcome, because it causes problems for users that have extensions that
>> call the function and were compiled with its older definition.
>
> To confirm, ReorderBufferResetTXN() seems a static function and proposed patch
> does not modify *.h files. So they do not break the ABI and OK to remove, right?
```
File: reorderbuffer.c
2156: /*
2157: * Helper function for ReorderBufferProcessTXN to handle the concurrent
2158: * abort of the streaming transaction. This resets the TXN such that it
2159: * can be used to stream the remaining data of transaction being processed.
2160: * This can happen when the subtransaction is aborted and we still want to
2161: * continue processing the main or other subtransactions data.
2162: */
2163: static void
2164: ReorderBufferResetTXN(ReorderBuffer *rb, ReorderBufferTXN *txn,
```
Confirmed, `ReorderBufferResetTXN()` is a static function used only by ReorderBufferProcessTXN().
It is not exposed outside reorderbuffer.c, and the patch does not affect any public exported function.
Regards,
Vishal Prasanna
Zoho Corporation
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: RE: [BUG] Assert failure in ReorderBufferReturnTXN during logical decoding due to leaked specinsert change
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox