From: Michael Paquier <michael@paquier.xyz>
To: Sergei Kornilov <sk@zsrv.org>
Cc: lizenko79@gmail.com <lizenko79@gmail.com>
Cc: pgsql-bugs@lists.postgresql.org <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #15252: "do not dump comments" in pg_restore help
Date: Tue, 26 Jun 2018 15:02:04 +0900
Message-ID: <20180626060204.GE31353@paquier.xyz> (raw)
In-Reply-To: <6993521529922398@web45j.yandex.ru>
References: <152992021588.1268.16786093506650391435@wrigleys.postgresql.org>
<6993521529922398@web45j.yandex.ru>
On Mon, Jun 25, 2018 at 01:26:38PM +0300, Sergei Kornilov wrote:
> Thank you! I recheck behavior too, option works correct and has only
> wrong description. Simple patch attached.
This is clearly a copy-pasto from recent commit 1368e92, nice catch.
> <listitem>
> <para>
> - Do not dump comments.
> + Do not restore comments.
> </para>
> </listitem>
> </varlistentry>
This is not consistent with the other --no-XXX switches, so I have
reworded the documentation fix to be more consistent with the rest and
pushed the patch. I can confirm as well after some manual testing that
the feature behaves as documented.
Thanks for the report and the patch!
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: michael@paquier.xyz, sk@zsrv.org, lizenko79@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15252: "do not dump comments" in pg_restore help
In-Reply-To: <20180626060204.GE31353@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox