pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed

From: Sergei Kornilov <sk@zsrv.org>
To: lizenko79@gmail.com <lizenko79@gmail.com>
To: pgsql-bugs@lists.postgresql.org <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #15252: "do not dump comments" in pg_restore help
Date: Mon, 25 Jun 2018 13:26:38 +0300
Message-ID: <6993521529922398@web45j.yandex.ru> (raw)
In-Reply-To: <152992021588.1268.16786093506650391435@wrigleys.postgresql.org>
References: <152992021588.1268.16786093506650391435@wrigleys.postgresql.org>

Hello
Thank you! I recheck behavior too, option works correct and has only wrong description. Simple patch attached.

regards, Sergei

Attachments:

bug15252_pg_restore_no_comments_description.patch (text/x-diff, 1.2K) download
diff --git a/doc/src/sgml/ref/pg_restore.sgml b/doc/src/sgml/ref/pg_restore.sgml
index 345324b..14ac22b 100644
--- a/doc/src/sgml/ref/pg_restore.sgml
+++ b/doc/src/sgml/ref/pg_restore.sgml
@@ -579,7 +579,7 @@
       <term><option>--no-comments</option></term>
       <listitem>
        <para>
-        Do not dump comments.
+        Do not restore comments.
        </para>
       </listitem>
      </varlistentry>
diff --git a/src/bin/pg_dump/pg_restore.c b/src/bin/pg_dump/pg_restore.c
index 2342a63..501d7ce 100644
--- a/src/bin/pg_dump/pg_restore.c
+++ b/src/bin/pg_dump/pg_restore.c
@@ -483,7 +483,7 @@ usage(const char *progname)
 	printf(_("  --disable-triggers           disable triggers during data-only restore\n"));
 	printf(_("  --enable-row-security        enable row security\n"));
 	printf(_("  --if-exists                  use IF EXISTS when dropping objects\n"));
-	printf(_("  --no-comments                do not dump comments\n"));
+	printf(_("  --no-comments                do not restore comments\n"));
 	printf(_("  --no-data-for-failed-tables  do not restore data of tables that could not be\n"
 			 "                               created\n"));
 	printf(_("  --no-publications            do not restore publications\n"));

view thread (3+ messages)  latest in thread

Message-ID: <6993521529922398@web45j.yandex.ru>
Permalink:  ../6993521529922398@web45j.yandex.ru/
Also on:    postgresql.org/message-id/6993521529922398@web45j.yandex.ru

copy link · copy postgr.es · copy git am

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: sk@zsrv.org, lizenko79@gmail.com, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #15252: "do not dump comments" in pg_restore help
  In-Reply-To: <6993521529922398@web45j.yandex.ru>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox