From: Michael Paquier <michael@paquier.xyz>
To: Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>
Cc: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
Cc: Luis Carril <luis.carril@swarm64.com>
Cc: pgsql-bugs@lists.postgresql.org <pgsql-bugs@lists.postgresql.org>
Cc: PG Bug reporting form <noreply@postgresql.org>
Cc: Michael Paquier <michael.paquier@gmail.com>
Subject: Re: BUG #15552: Unexpected error in COPY to a foreign table in a transaction
Date: Fri, 21 Dec 2018 13:07:24 +0900
Message-ID: <20181221040724.GF1886@paquier.xyz> (raw)
In-Reply-To: <5C1C62C5.8040409@lab.ntt.co.jp>
References: <5C18ECBB.2000507@lab.ntt.co.jp>
<LEJPR01MB001074FD67CB65B539122E4DE7BD0@LEJPR01MB0010.DEUPRD01.PROD.OUTLOOK.DE>
<3539e73a-313a-5406-27c7-850affb47921@lab.ntt.co.jp>
<20181219023814.GA6577@paquier.xyz>
<6daa6d4a-d4a9-bd2c-0b84-c4e31d2b9844@lab.ntt.co.jp>
<5C19F7FF.9060904@lab.ntt.co.jp>
<20181219083422.GA680@paquier.xyz>
<5C1A0B6C.1040502@lab.ntt.co.jp>
<20181220003140.GE27104@paquier.xyz>
<5C1C62C5.8040409@lab.ntt.co.jp>
On Fri, Dec 21, 2018 at 12:49:25PM +0900, Etsuro Fujita wrote:
> (2018/12/20 9:31), Michael Paquier wrote:
>> Attached is the patch with two new test cases blowing with wal_level =
>> minimal. On HEAD, I suggest that we use RELKIND_CAN_HAVE_STORAGE to not
>> fall again in this trap in the future. For back-branches, let's just
>> add the appropriate relkind checks as suggested upthread.
>
> To make maintenance easy, I think it might be better to add the appropriate
> relkind checks on HEAD as well. Other than that, the patch looks good to
> me.
Well, using RELKIND_CAN_HAVE_STORAGE is exactly to ease future
maintenance so as we don't fall again into the same trap if a new
relkind which has no physical storage gets introduced if it supports
COPY FROM. So I would keep really it on HEAD.
> Thanks for the updated patch!
And thanks for taking the time to review the patch.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../20181221040724.GF1886@paquier.xyz/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: michael@paquier.xyz, fujita.etsuro@lab.ntt.co.jp, Langote_Amit_f8@lab.ntt.co.jp, luis.carril@swarm64.com, pgsql-bugs@lists.postgresql.org, noreply@postgresql.org, michael.paquier@gmail.com
Subject: Re: BUG #15552: Unexpected error in COPY to a foreign table in a transaction
In-Reply-To: <20181221040724.GF1886@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox