From: Michael Paquier <michael@paquier.xyz>
To: Hugh Ranalli <hugh@whtc.ca>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: thomas.munro@enterprisedb.com, Daniel Verite <daniel@manitou-mail.org>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15548: Unaccent does not remove combining diacritical characters
Date: Thu, 10 Jan 2019 15:09:45 +0900
Message-ID: <20190110060945.GL2157@paquier.xyz> (raw)
In-Reply-To: <CAAhbUMNZ0ooK6SzLNdkxzdBsQHOJf_rg_EjwoNL8QHTwQuriRw@mail.gmail.com>
References: <201901031819.hi4hjki2pzr5@alvherre.pgsql>
<23619.1546539744@sss.pgh.pa.us>
<CAAhbUMMrNL9uXXpwS+BPTGjKQv5Sxvr+OY2C73Ag7oFyjSOiEQ@mail.gmail.com>
<20190104130048.GD2067@paquier.xyz>
<CAAhbUMOj8r4=V0nQpa21SBh7tHTZ37QxXKx5JSpYqdsA-V6mSA@mail.gmail.com>
<20190109035253.GF21835@paquier.xyz>
<CAAhbUMNZ0ooK6SzLNdkxzdBsQHOJf_rg_EjwoNL8QHTwQuriRw@mail.gmail.com>
On Wed, Jan 09, 2019 at 09:52:05PM -0500, Hugh Ranalli wrote:
> Thank you for putting so much effort into this. I think that looks great.
> When I was doing this, I discovered that I could parse both pre- and post-
> r29 versions, so I went with that, but I agree that there's probably no
> good reason to do so.
OK, committed then. I have yet to study yet the other part of the
proposal regarding diatritical characters. Patch 3 has a conflict for
the regression tests, so a rebase would be needed. That's not a big
deal though to resolve the conflict. I am also a bit confused by the
newly-generated unaccent.rules. Why nothing shows up for the second
column (around line 414 for example)? Shouldn't we have mapping
characters?
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../20190110060945.GL2157@paquier.xyz/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: michael@paquier.xyz, hugh@whtc.ca, tgl@sss.pgh.pa.us, alvherre@2ndquadrant.com, peter.eisentraut@2ndquadrant.com, daniel@manitou-mail.org, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15548: Unaccent does not remove combining diacritical characters
In-Reply-To: <20190110060945.GL2157@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox