pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Thomas Munro <thomas.munro@enterprisedb.com>
Cc: John Klann <jk7255@gmail.com>
Cc: PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #15636: PostgreSQL 11.1 pg_basebackup backup to a CIFS destination throws fsync error at end of backup
Date: Mon, 18 Feb 2019 12:28:43 +0900
Message-ID: <20190218032843.GD15532@paquier.xyz> (raw)
In-Reply-To: <CAEepm=3ZqWB0csmLx+mYeUa1DDjaTt5k5hA2=3mcGMG2aCoASQ@mail.gmail.com>
References: <CAHyX5+XqkmHwxLC5aeYOjHFAvnf8X1o3grkzGJOvc-kOGpjQ8g@mail.gmail.com>
	<CAHyX5+VO-UTE-pK2i1rWvweU2CpVtHuhXnok29Z66EpLHmiHvw@mail.gmail.com>
	<CAEepm=05ff+GRYdVE7+SdDuTVbPqW+Gmpwqir0NtAWNM70jg3g@mail.gmail.com>
	<CAHyX5+W2OXAg=qEnObA3g4zU3SkwxTztSfmgmivWnWQWcsc_tA@mail.gmail.com>
	<CAEepm=1P0WD_g=ELNmBJFhwKuCjYZOi4p4rutKj3kw7QneLB2A@mail.gmail.com>
	<CAHyX5+UxmOn-qpb+++NOr3MfZiXk6WZDKFYTEj+vPbu+3nrhXg@mail.gmail.com>
	<CAHyX5+X60D0jtf4dgyt11mH=7XvuW1UOLstY9sBLgukyf8Oo4g@mail.gmail.com>
	<CAEepm=27vTw2xyTh5kAXns8h5zOKUmzBxUL82c-KFFgyUQ0MHw@mail.gmail.com>
	<20190218025511.GA15532@paquier.xyz>
	<CAEepm=3ZqWB0csmLx+mYeUa1DDjaTt5k5hA2=3mcGMG2aCoASQ@mail.gmail.com>

On Mon, Feb 18, 2019 at 04:10:58PM +1300, Thomas Munro wrote:
> Well the theory is that it's OK because it's only for directories (the
> same case in which case we already tolerate EBADF (for an OS that
> nobody documented so we don't really know if/when we can take it
> out)).  But I agree with you that the patch does not spark joy.

If I would vote for this patch, that would be -0.1, meaning that I am
not strongly opposed to it, but I don't see any strong point either to
do something about it as there are downsides.  When in doubt about a
back-patch, I use as basic rule to never back-patch so as we are sure
that users avoid any surprises and keep relying on the existing
design.
--
Michael

Attachments:

  [application/pgp-signature] signature.asc (832B, ../20190218032843.GD15532@paquier.xyz/2-signature.asc)
  download

view thread (18+ messages)  latest in thread

Message-ID: <20190218032843.GD15532@paquier.xyz>
Permalink:  ../20190218032843.GD15532@paquier.xyz/
Also on:    postgresql.org/message-id/20190218032843.GD15532@paquier.xyz

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: michael@paquier.xyz, thomas.munro@enterprisedb.com, jk7255@gmail.com, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #15636: PostgreSQL 11.1 pg_basebackup backup to a CIFS destination throws fsync error at end of backup
  In-Reply-To: <20190218032843.GD15532@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox