From: Michael Paquier <michael@paquier.xyz>
To: cyberdemn@gmail.com
To: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15734: Walsender process crashing when executing SHOW ALL;
Date: Mon, 8 Apr 2019 16:39:03 +0900
Message-ID: <20190408073903.GJ2712@paquier.xyz> (raw)
In-Reply-To: <15734-2daa8761eeed8e20@postgresql.org>
References: <15734-2daa8761eeed8e20@postgresql.org>
On Thu, Apr 04, 2019 at 07:54:19AM +0000, PG Bug reporting form wrote:
> I don't think that such a crash is expected behavior. Either it should
> return the table with all settings or report simply error out with message
> 'unrecognized configuration parameter "ALL"'.
No, it's not correct to just disallow ALL as we have a similar check
in GetConfigOptionByName() for individual parameters.
Problem is origically from 25fff40, and got worse as of 0c8910a0. A
superuser is able to get the list of parameters, but I can easily see
the failure when using a plain replication user. A replication user
is one which can take a full base backup, so he can easily retrieve
the full list of parameters anyway. What about bypassing the problem
and just allow WAL sender contexts to always have access to parameter
values? I don't think that this is much a security issue if one
thinks about the access to BASE_BACKUP.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: michael@paquier.xyz, cyberdemn@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15734: Walsender process crashing when executing SHOW ALL;
In-Reply-To: <20190408073903.GJ2712@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox