From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Yuli Khodorkovskiy <yuli.khodorkovskiy@crunchydata.com>
Cc: pgsql-bugs@lists.postgresql.org, Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Subject: Re: BUG #15804: Assertion failure when using logging_collector with EXEC_BACKEND
Date: Thu, 16 May 2019 13:36:18 +0900
Message-ID: <20190516043618.GD1415@paquier.xyz> (raw)
In-Reply-To: <20190516035617.GC1415@paquier.xyz>
References: <15804-3721117bf40fb654@postgresql.org>
<27CD45B5-88F7-4A09-8B31-EFE41FC37FE1@crunchydata.com>
<26332.1557863524@sss.pgh.pa.us>
<20190515073125.GA1517@paquier.xyz>
<4643.1557931189@sss.pgh.pa.us>
<20190516013808.GA1415@paquier.xyz>
<20190516021903.GB1415@paquier.xyz>
<28927.1557977558@sss.pgh.pa.us>
<20190516035617.GC1415@paquier.xyz>
On Thu, May 16, 2019 at 12:56:17PM +0900, Michael Paquier wrote:
> The test is able to pass, but we have a race condition between the
> moment the backend file gets saved and the moment we allow it to be
> read. I have not spent much time checking the stack between
> InitializeMaxBackends() and RemovePgTempFiles() in postmaster.c, but
> 57431a9 triggers the failure.
Oh, I think I got it. The issue is that we call RemovePgTempFiles()
after starting the syslogger. This cannot be run with other processes
running in parallel, and with EXEC_BACKEND there is the extra case
where we have a pgsql_tmp/ at the root of the data folder, so the
syslogger complains on that. By making RemovePgTempFiles() happen
before starting the syslogger, then the test complains again about the
assertion without my previous patch applied of course. With the patch
applied, I get no complains.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../20190516043618.GD1415@paquier.xyz/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: michael@paquier.xyz, tgl@sss.pgh.pa.us, yuli.khodorkovskiy@crunchydata.com, peter.eisentraut@2ndquadrant.com
Subject: Re: BUG #15804: Assertion failure when using logging_collector with EXEC_BACKEND
In-Reply-To: <20190516043618.GD1415@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox