From: Michael Paquier <michael@paquier.xyz>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Dilip Kumar <dilipbalaut@gmail.com>
Cc: jungleboogie0@gmail.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15964: vacuumdb.c:187:10: error: use of undeclared identifier 'FD_SETSIZE'
Date: Wed, 21 Aug 2019 16:36:19 +0900
Message-ID: <20190821073619.GC26424@paquier.xyz> (raw)
In-Reply-To: <20190821024005.GA16883@alvherre.pgsql>
References: <20190821015854.GD1684@paquier.xyz>
<20190821024005.GA16883@alvherre.pgsql>
On Tue, Aug 20, 2019 at 10:40:05PM -0400, Alvaro Herrera wrote:
> On 2019-Aug-21, Michael Paquier wrote:
>
> > + if (PQsocket(conn) >= FD_SETSIZE)
> > + {
> > + fprintf(stderr, "too many jobs for this platform's select()\n");
> > + exit(1);
> > + }
>
> BTW why fprintf? Since you can get into this by careless use of -j,
> ISTM that this should be a translatable string. I'd consider
> pg_log_fatal(). Maybe something like "Argument of -j too large for this
> platform -- try %d", numslots - i.
If giving a recommendation, shouldn't that be linked only to "i"
instead? If for example numslots = 1024, but that we get an error
after allocating 128 slots because of a lack of fds in the range, then
we would recommend 896, which would still result in an error. I quite
like the suggestion from Andres to keep the message simple with "too
many jobs for this platform's select()". You are indeed right about
the pg_log_fatal() part here, I have changed the patch to do that on
my local branch.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../20190821073619.GC26424@paquier.xyz/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: michael@paquier.xyz, alvherre@2ndquadrant.com, andres@anarazel.de, tgl@sss.pgh.pa.us, dilipbalaut@gmail.com, jungleboogie0@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15964: vacuumdb.c:187:10: error: use of undeclared identifier 'FD_SETSIZE'
In-Reply-To: <20190821073619.GC26424@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox