pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed

From: Tomas Vondra <tomas.vondra@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andres Freund <andres@anarazel.de>
Cc: buschmann@nidsa.net
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16045: vacuum_db crash and illegal memory alloc after pg_upgrade from PG11 to PG12
Date: Tue, 15 Oct 2019 02:18:17 +0200
Message-ID: <20191015001817.zei45apgpu5dzngr@development> (raw)
In-Reply-To: <20191014163538.cqn6j4cl7s2mk2yz@development>
References: <20191010134303.bkwjzchjb2w66iro@development>
	<30706.1570717152@sss.pgh.pa.us>
	<20191010163350.2rtcjtje6tkgilqi@development>
	<1542.1570738460@sss.pgh.pa.us>
	<20191010204022.6hiiubm2cueu3ghk@development>
	<20191013001032.lqrn4kqaovhrf77l@development>
	<17717.1570991208@sss.pgh.pa.us>
	<20191013203848.2eksimmpux3546wr@development>
	<27596.1571062600@sss.pgh.pa.us>
	<20191014163538.cqn6j4cl7s2mk2yz@development>

On Mon, Oct 14, 2019 at 06:35:38PM +0200, Tomas Vondra wrote:
> ...
>
>Aha! I forgot we copy the necessary stuff into pg_attribute. Thanks for
>clarifying, I'll polish and push the fix shortly.
>

I've pushed and backpatched the fix. Attached are similar fixes for the
existing pg_upgrade checks for pg_catalog.line and pg_catalog.unknown
types, which have the same issues with composite types and domains.

There are some additional details & examples in the commit messages.

I've kept this in two patches primarily because of backpatching - the
line fix should go back up to 9.4, the unknown is for 10.

regards

-- 
Tomas Vondra                  http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


Attachments:

  [text/plain] 0001-Correct-the-check-for-pg_catalog.line-in-pg_upgrade.patch (0B, ../20191015001817.zei45apgpu5dzngr@development/2-0001-Correct-the-check-for-pg_catalog.line-in-pg_upgrade.patch)
  download

view thread (30+ messages)  latest in thread

Message-ID: <20191015001817.zei45apgpu5dzngr@development>
Permalink:  ../20191015001817.zei45apgpu5dzngr@development/
Also on:    postgresql.org/message-id/20191015001817.zei45apgpu5dzngr@development

copy link · copy postgr.es · copy git am

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: tomas.vondra@2ndquadrant.com, tgl@sss.pgh.pa.us, andres@anarazel.de, buschmann@nidsa.net, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #16045: vacuum_db crash and illegal memory alloc after pg_upgrade from PG11 to PG12
  In-Reply-To: <20191015001817.zei45apgpu5dzngr@development>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox