pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Jobin Augustine <jobinau@gmail.com>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Oleksandr Shulgin <oleksandr.shulgin@zalando.de>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: libpq parameter parsing problem
Date: Tue, 14 Jan 2020 18:56:17 -0300
Message-ID: <20200114215617.GA18330@alvherre.pgsql> (raw)
In-Reply-To: <20200114085505.GA83028@paquier.xyz>

On 2020-Jan-14, Michael Paquier wrote:

> On Tue, Jan 14, 2020 at 12:01:43PM +0530, Jobin Augustine wrote:
> > Yes, agree, readability is better with that modification.
> > Attaching a modified patch.
> 
> (Please always top-post, this is the style of the PostgreSQL community
> mailing lists).  The new patch looks good to me, let's see if others
> have extra thoughts to share.  If not, I'll try to commit it.

The thought I had when I first saw this was that it would be better to
have a minimal, coherent set of useful examples all together in a
subsection called Examples.  But then I realized that random examples
are already scattered here and there in the libpq page, so while I still
think that that would be better, I no longer think it's this patch's
responsibility to make it so.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services





view thread (22+ messages)  latest in thread

Message-ID: <20200114215617.GA18330@alvherre.pgsql>
Permalink:  ../20200114215617.GA18330@alvherre.pgsql/
Also on:    postgresql.org/message-id/20200114215617.GA18330@alvherre.pgsql

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-bugs@postgresql.org
  Cc: alvherre@2ndquadrant.com, michael@paquier.xyz, jobinau@gmail.com, hlinnaka@iki.fi, oleksandr.shulgin@zalando.de
  Subject: Re: libpq parameter parsing problem
  In-Reply-To: <20200114215617.GA18330@alvherre.pgsql>
  References: <20200114085505.GA83028@paquier.xyz> <20200114215617.GA18330@alvherre.pgsql>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox