pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: David Steele <david@pgmasters.net>
Cc: Pavel Suderevsky <psuderevsky@gmail.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: Don't try fetching future segment of a TLI.
Date: Tue, 7 Apr 2020 17:17:32 +0900
Message-ID: <20200407081732.GC6655@paquier.xyz> (raw)
In-Reply-To: <3e0713d2-56d2-9883-4213-d5ba7f0dcabf@oss.nttdata.com>
References: <16159-f5a34a3a04dc67e0@postgresql.org>
	<20191212.124856.202839248708529678.horikyota.ntt@gmail.com>
	<CAEBTBzsi8HrTTSC1xwL0otzrwdefRSLuwdQ7LnAs+jQeN+EJ8A@mail.gmail.com>
	<20200129.120222.1476610231001551715.horikyota.ntt@gmail.com>
	<8c831a30-a3a2-de89-2059-e7ce842d7aed@pgmasters.net>
	<CAEBTBzupObE6Gep1y-ajvUh4AjuvyTmfTewshVOei12uRV=Q8Q@mail.gmail.com>
	<792ea085-95c4-bca0-ae82-47fdc80e146d@oss.nttdata.com>
	<762ffb60-df9c-0efc-2714-9859219157e3@pgmasters.net>
	<3e0713d2-56d2-9883-4213-d5ba7f0dcabf@oss.nttdata.com>

On Tue, Apr 07, 2020 at 12:15:00PM +0900, Fujii Masao wrote:
> I understood the situation and am fine to back-patch that. But I'm not sure
> if it's fair to do that. Maybe we need to hear more opinions about this?
> OTOH, feature freeze for v13 is today, so what about committing the patch
> in v13 at first, and then doing the back-patch after hearing opinions and
> receiving many +1?

I have not looked at the patch so I cannot say much about it, but it
is annoying to fetch segments you are not going to need anyway if you
target recovery with a timeline older than the segments fetched and
this has a cost when you pay for the bandwidth of your environment
with only one archive location.  So a backpatch sounds like a good
thing to do even if recovery is not broken per-se, only slower.

Designing a TAP test for that is tricky, but you could look at the
logs of the backend to make sure that only the wanted segments are
fetched with a central archived solution and multiple timelines
involved.  And costly it is.
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (13+ messages)  latest in thread

Message-ID: <20200407081732.GC6655@paquier.xyz>
Permalink:  ../20200407081732.GC6655@paquier.xyz/
Also on:    postgresql.org/message-id/20200407081732.GC6655@paquier.xyz

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: michael@paquier.xyz, masao.fujii@oss.nttdata.com, david@pgmasters.net, psuderevsky@gmail.com, horikyota.ntt@gmail.com, pgsql-hackers@lists.postgresql.org, pgsql-bugs@lists.postgresql.org
  Subject: Re: Don't try fetching future segment of a TLI.
  In-Reply-To: <20200407081732.GC6655@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox