pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Stephen Frost <sfrost@snowman.net>
To: Bruce Momjian <bruce@momjian.us>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Jeff Janes <jeff.janes@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: ram.maurya@lavainternational.in, pgsql-bugs <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #16497: old and new pg_controldata WAL segment sizes are invalid or do not match
Date: Thu, 18 Jun 2020 11:55:37 -0400
Message-ID: <20200618155537.GC6680@tamriel.snowman.net> (raw)
In-Reply-To: <20200618154854.GG7349@momjian.us>
References: <16497-38bb1f1bcec44964@postgresql.org>
	<20200618080509.GH118592@paquier.xyz>
	<CAMkU=1zRirCC-kZTZb0hBq+jqy7vjk8+ehbrZpjr5LATKFChKQ@mail.gmail.com>
	<1549966.1592493410@sss.pgh.pa.us>
	<20200618152911.GF7349@momjian.us>
	<20200618154152.GB6680@tamriel.snowman.net>
	<20200618154854.GG7349@momjian.us>

Greetings,

* Bruce Momjian (bruce@momjian.us) wrote:
> On Thu, Jun 18, 2020 at 11:41:53AM -0400, Stephen Frost wrote:
> > Sure, most options to initdb need to be the same between the old cluster
> > and the new cluster, but this specific option doesn't have to be, since
> > we require that it's a cleanly shut down cluster, so why are we
> > complaining about it if it's different..?
> 
> Did you not read my previous email that we might have added this so we
> can upgrade replicas?

I don't see how this option is related to dealing with replicas..?

> I am sure I can dig out the commit that added
> this and find the original cause, but running pg_upgrade on replicas is
> enough of a reason to me.

pg_upgrade can't be run on replicas, so I don't understand what you're
referring to here..  The 'upgrading replicas' process that involves
rsync also requires everything to have been shut down cleanly.

> Yeah, we could add a flag to pg_upgrade to
> allow this if you are not upgrading replicas, but why bother?  It might
> even work if you create the new replicas with the same WAL segment size,
> but why add complexity for pg_upgrade, which is already complex enough.

Users already have to deal with various options that need to be
configured to match up between the primary and replicas, so this really
seems like it's entirely independent of pg_upgrade and isn't something
pg_upgrade needs to be worrying about..

Thanks,

Stephen

Attachments:

  signature.asc (application/pgp-signature, 818B) download

view thread (25+ messages)  latest in thread

Message-ID: <20200618155537.GC6680@tamriel.snowman.net>
Permalink:  ../20200618155537.GC6680@tamriel.snowman.net/
Also on:    postgresql.org/message-id/20200618155537.GC6680@tamriel.snowman.net

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: sfrost@snowman.net, bruce@momjian.us, tgl@sss.pgh.pa.us, jeff.janes@gmail.com, michael@paquier.xyz, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #16497: old and new pg_controldata WAL segment sizes are invalid or do not match
  In-Reply-To: <20200618155537.GC6680@tamriel.snowman.net>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox