pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Stephen Frost <sfrost@snowman.net>
To: Bruce Momjian <bruce@momjian.us>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Jeff Janes <jeff.janes@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: ram.maurya@lavainternational.in, pgsql-bugs <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #16497: old and new pg_controldata WAL segment sizes are invalid or do not match
Date: Thu, 18 Jun 2020 14:11:14 -0400
Message-ID: <20200618181114.GG6680@tamriel.snowman.net> (raw)
In-Reply-To: <20200618180058.GK7349@momjian.us>
References: <20200618080509.GH118592@paquier.xyz>
	<CAMkU=1zRirCC-kZTZb0hBq+jqy7vjk8+ehbrZpjr5LATKFChKQ@mail.gmail.com>
	<1549966.1592493410@sss.pgh.pa.us>
	<20200618152911.GF7349@momjian.us>
	<20200618154152.GB6680@tamriel.snowman.net>
	<20200618154854.GG7349@momjian.us>
	<20200618155537.GC6680@tamriel.snowman.net>
	<20200618163615.GI7349@momjian.us>
	<20200618174241.GD6680@tamriel.snowman.net>
	<20200618180058.GK7349@momjian.us>

Greetings,

* Bruce Momjian (bruce@momjian.us) wrote:
> On Thu, Jun 18, 2020 at 01:42:41PM -0400, Stephen Frost wrote:
> > > > > Yeah, we could add a flag to pg_upgrade to
> > > > > allow this if you are not upgrading replicas, but why bother?  It might
> > > > > even work if you create the new replicas with the same WAL segment size,
> > > > > but why add complexity for pg_upgrade, which is already complex enough.
> > > > 
> > > > Users already have to deal with various options that need to be
> > > > configured to match up between the primary and replicas, so this really
> > > > seems like it's entirely independent of pg_upgrade and isn't something
> > > > pg_upgrade needs to be worrying about..
> > > 
> > > Do you know why we require this step?
> > > 
> > > 	https://www.postgresql.org/docs/12/pgupgrade.html
> > > 	
> > > 	Also, change wal_level to replica in the postgresql.conf file on
> > > 	the new primary cluster.
> > 
> > Well, we'll need wal_level to be at least replica if we're going to have
> > replicas streaming from the primary..
> 
> But how do they have replicas if wal_level = minimum?  Also, why not
> higher replication levels?  Should we adjust that doc text?

I think the comment is saying that pg_resetwal will rewrite the
pg_control with a WAL level of minimal and that's the issue and why
the server needs to be brought up with a higher WAL level temporarily,
so that pg_control gets updated, for the new cluster.

Of course, before pg_upgrade is run, the old cluster would need to be up
and running with a wal_level higher than minimal in order to have
replicas in the first place, but what we're really talking about here is
the new, upgraded, cluster.

I do think the doc could probably say replica 'or higher'.

Thanks,

Stephen

Attachments:

  signature.asc (application/pgp-signature, 818B) download

view thread (25+ messages)  latest in thread

Message-ID: <20200618181114.GG6680@tamriel.snowman.net>
Permalink:  ../20200618181114.GG6680@tamriel.snowman.net/
Also on:    postgresql.org/message-id/20200618181114.GG6680@tamriel.snowman.net

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: sfrost@snowman.net, bruce@momjian.us, tgl@sss.pgh.pa.us, jeff.janes@gmail.com, michael@paquier.xyz, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #16497: old and new pg_controldata WAL segment sizes are invalid or do not match
  In-Reply-To: <20200618181114.GG6680@tamriel.snowman.net>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox