From: Bruce Momjian <bruce@momjian.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: David G. Johnston <david.g.johnston@gmail.com>
Cc: Laurenz Albe <laurenz.albe@cybertec.at>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: BUG #16419: wrong parsing BC year in to_date() function
Date: Wed, 30 Sep 2020 19:41:47 -0400
Message-ID: <20200930234147.GI26841@momjian.us> (raw)
In-Reply-To: <943476.1601508415@sss.pgh.pa.us>
References: <CAKFQuwb_3yNTTE6cG_YtXFtV=CkQf0uMSMB0oxC1YNrF94pfuA@mail.gmail.com>
<20200904012149.GA13932@momjian.us>
<CAKFQuwZV0UxbyYTxuJhf1j1X=3HG5QA6qtEp+C+=LzOFtNEt3A@mail.gmail.com>
<20200904201224.GD6891@momjian.us>
<663099.1601400389@sss.pgh.pa.us>
<CA+TgmoameT7ysPOm2sqp6NaZtzP0QFNjJ09wC1QVKTzt-84D7Q@mail.gmail.com>
<911841.1601501743@sss.pgh.pa.us>
<CA+TgmoaZ9w=WwmE3xRUCN0bSzYp14kU6_MAy-wJUpgpDmVMYpA@mail.gmail.com>
<20200930223656.GH26841@momjian.us>
<943476.1601508415@sss.pgh.pa.us>
On Wed, Sep 30, 2020 at 07:26:55PM -0400, Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
> > On Wed, Sep 30, 2020 at 06:10:38PM -0400, Robert Haas wrote:
> >> On Wed, Sep 30, 2020 at 5:35 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> >>> By that logic, we should never fix any bug in a back branch.
>
> >> No, by that logic, we should not change any behavior in a back-branch
> >> upon which a customer is plausibly relying. No one relies on a certain
> >> query causing a server crash, for example, or a cache lookup failure,
> >> so fixing those things can only help people. But there is no reason at
> >> all why someone shouldn't be relying on this very old and
> >> long-established behavior not to change in a minor release.
>
> > That is an interesting distinction.
>
> I don't want to sound like I'm totally without sympathy for Robert's
> argument. But I do say it's a judgment call, and my judgment remains
> that this patch is appropriate to back-patch.
Agreed. I was just thinking it was an interesting classification that
no one relies on crashes, or query failures.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EnterpriseDB https://enterprisedb.com
The usefulness of a cup is in its emptiness, Bruce Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: bruce@momjian.us, tgl@sss.pgh.pa.us, robertmhaas@gmail.com, david.g.johnston@gmail.com, laurenz.albe@cybertec.at, pgsql-hackers@lists.postgresql.org
Subject: Re: BUG #16419: wrong parsing BC year in to_date() function
In-Reply-To: <20200930234147.GI26841@momjian.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox