From: Bruce Momjian <bruce@momjian.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: David G. Johnston <david.g.johnston@gmail.com>
Cc: exclusion@gmail.com, PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #16486: Prompted password is ignored when password specified in connection string
Date: Fri, 2 Oct 2020 22:19:58 -0400
Message-ID: <20201003021958.GC17425@momjian.us> (raw)
In-Reply-To: <20200903190538.GA3248@momjian.us>
References: <16486-b9c93d71c02c4907@postgresql.org>
<2090524.1591652199@sss.pgh.pa.us>
<CAKFQuwbk=SDVVhe=P=eAsX4Zip_0tR+vZOOMM-VvHAH0=We=_g@mail.gmail.com>
<2110959.1591655226@sss.pgh.pa.us>
<2142411.1591667958@sss.pgh.pa.us>
<20200901203846.GA13613@momjian.us>
<428207.1599076060@sss.pgh.pa.us>
<20200903190538.GA3248@momjian.us>
On Thu, Sep 3, 2020 at 03:05:38PM -0400, Bruce Momjian wrote:
> On Wed, Sep 2, 2020 at 03:47:40PM -0400, Tom Lane wrote:
> > Bruce Momjian <bruce@momjian.us> writes:
> > > I used a later version of Tom's patch to add documentation of how
> > > connection strings can override command-line options, plus it has the
> > > password description improvements.
> >
> > > <option>--all</option>) is not used, the database name is read
> > > from the environment variable <envar>PGDATABASE</envar>. If
> > > that is not set, the user name specified for the connection is
> > > - used.
> > > + used. <link linkend="libpq-connstring">Connction strings</link>
> > > + can also be used for connection specifications, and these can
> > > + override other command-line options.
> > > </para>
> > > </listitem>
> > > </varlistentry>
> >
> > * Spellcheck (not "Connction" please)
> >
> > * I do not like the wording "can override", because that's just impossibly
> > vague. It leaves the reader wondering whether there are cases where that
> > doesn't happen.
> >
> > I'd suggest wording more like
> >
> > The <replaceable>dbname</replaceable> can be a
> > <link ...>connection string</link>. If so, connection parameters
> > found in the connection string will override any conflicting command
> > line options, such as <option>--username</option>.
>
> Sure, makes sense. Updated patch attached.
Patch applied to all supported versions; thanks for the report.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EnterpriseDB https://enterprisedb.com
The usefulness of a cup is in its emptiness, Bruce Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: bruce@momjian.us, tgl@sss.pgh.pa.us, david.g.johnston@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16486: Prompted password is ignored when password specified in connection string
In-Reply-To: <20201003021958.GC17425@momjian.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox