pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Bruce Momjian <bruce@momjian.us>
Cc: David G. Johnston <david.g.johnston@gmail.com>
Cc: exclusion@gmail.com, PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #16486: Prompted password is ignored when password specified in connection string
Date: Wed, 02 Sep 2020 15:47:40 -0400
Message-ID: <428207.1599076060@sss.pgh.pa.us> (raw)
In-Reply-To: <20200901203846.GA13613@momjian.us>
References: <16486-b9c93d71c02c4907@postgresql.org>
	<2090524.1591652199@sss.pgh.pa.us>
	<CAKFQuwbk=SDVVhe=P=eAsX4Zip_0tR+vZOOMM-VvHAH0=We=_g@mail.gmail.com>
	<2110959.1591655226@sss.pgh.pa.us>
	<2142411.1591667958@sss.pgh.pa.us>
	<20200901203846.GA13613@momjian.us>

Bruce Momjian <bruce@momjian.us> writes:
> I used a later version of Tom's patch to add documentation of how
> connection strings can override command-line options, plus it has the
> password description improvements.

>          <option>--all</option>) is not used, the database name is read
>          from the environment variable <envar>PGDATABASE</envar>.  If
>          that is not set, the user name specified for the connection is
> -        used.
> +        used.  <link linkend="libpq-connstring">Connction strings</link>
> +        can also be used for connection specifications, and these can
> +        override other command-line options.
>         </para>
>        </listitem>
>       </varlistentry>

* Spellcheck (not "Connction" please)

* I do not like the wording "can override", because that's just impossibly
vague.  It leaves the reader wondering whether there are cases where that
doesn't happen.

I'd suggest wording more like

    The <replaceable>dbname</replaceable> can be a
    <link ...>connection string</link>.  If so, connection parameters
    found in the connection string will override any conflicting command
    line options, such as <option>--username</option>.

			regards, tom lane





view thread (17+ messages)  latest in thread

Message-ID: <428207.1599076060@sss.pgh.pa.us>
Permalink:  ../428207.1599076060@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/428207.1599076060@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, bruce@momjian.us, david.g.johnston@gmail.com, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #16486: Prompted password is ignored when password specified in connection string
  In-Reply-To: <428207.1599076060@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox