From: Bruce Momjian <bruce@momjian.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Noah Misch <noah@leadboat.com>
Cc: neverov.max@gmail.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16939: Plural interval for negative singular
Date: Mon, 26 Apr 2021 12:54:35 -0400
Message-ID: <20210426165435.GT7629@momjian.us> (raw)
In-Reply-To: <2266336.1619455534@sss.pgh.pa.us>
References: <16939-cceeb03fb72736ee@postgresql.org>
<20210323160336.GE579@momjian.us>
<20210425115726.GA2353095@rfd.leadboat.com>
<20210426163116.GR7629@momjian.us>
<2266336.1619455534@sss.pgh.pa.us>
On Mon, Apr 26, 2021 at 12:45:34PM -0400, Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
> > On Sun, Apr 25, 2021 at 04:57:26AM -0700, Noah Misch wrote:
> >> Let's not change from one popular spelling to another when doing so creates a
> >> compatibility hazard. That is to say, I think PostgreSQL would be better with
> >> this patch reverted.
> >>
> >> If we did want to standardize on singular for -1, EVALUATE_MESSAGE_PLURAL()
> >> would be a key bit of code to change.
>
> > Oh, good point. I think we should just pick one and be consistent --- I
> > don't care which we choose.
>
> I agree with Noah's opinion that we should stick to the historical
> behavior in the interval I/O functions. There is not enough solidity
> in the "this is grammatically wrong" argument to justify taking any
> risk of application breakage, and it seems like there is some risk of
> that there.
>
> For the sorts of human-readable messages that EVALUATE_MESSAGE_PLURAL
> tends to be used for, I don't think there's a reason to worry that
> we might break applications if we change it. So I don't have a
> strong opinion about what to do there. Still, by the same token
> that the grammatical argument is weak, I lean towards not spending
> effort on changing it.
Are you saying we should revert the patch and leave the plurals
inconsistent in different places? We were already expressing -1 as
singular in most of the places I saw.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
If only the physical world exists, free will is an illusion.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: bruce@momjian.us, tgl@sss.pgh.pa.us, noah@leadboat.com, neverov.max@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16939: Plural interval for negative singular
In-Reply-To: <20210426165435.GT7629@momjian.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox