From: Bruce Momjian <bruce@momjian.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Noah Misch <noah@leadboat.com>
Cc: neverov.max@gmail.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16939: Plural interval for negative singular
Date: Mon, 26 Apr 2021 13:06:16 -0400
Message-ID: <20210426170616.GV7629@momjian.us> (raw)
In-Reply-To: <2267469.1619456564@sss.pgh.pa.us>
References: <16939-cceeb03fb72736ee@postgresql.org>
<20210323160336.GE579@momjian.us>
<20210425115726.GA2353095@rfd.leadboat.com>
<20210426163116.GR7629@momjian.us>
<2266336.1619455534@sss.pgh.pa.us>
<20210426165435.GT7629@momjian.us>
<2267469.1619456564@sss.pgh.pa.us>
On Mon, Apr 26, 2021 at 01:02:44PM -0400, Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
> > On Mon, Apr 26, 2021 at 12:45:34PM -0400, Tom Lane wrote:
> >> I agree with Noah's opinion that we should stick to the historical
> >> behavior in the interval I/O functions. There is not enough solidity
> >> in the "this is grammatically wrong" argument to justify taking any
> >> risk of application breakage, and it seems like there is some risk of
> >> that there.
>
> > Are you saying we should revert the patch and leave the plurals
> > inconsistent in different places?
>
> As far as the changes in datetime.c and interval.c are concerned,
> yes. I don't care too much about what you did in fe-print.c,
Well, we should then add a comment that this is inconsistent but should
not be changed.
> although TBH that case should be unreachable shouldn't it?
> When would PQntuples() return -1?
I changed that just for consistency with other calls, in case it is ever
copied somewhere else.
> (I shy gently away from the fact that that fe-print.c code is
> relentlessly untranslatable.)
Again, if we revert, we should document is via a C comment.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
If only the physical world exists, free will is an illusion.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: bruce@momjian.us, tgl@sss.pgh.pa.us, noah@leadboat.com, neverov.max@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16939: Plural interval for negative singular
In-Reply-To: <20210426170616.GV7629@momjian.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox