From: Álvaro Herrera <alvherre@kurilemu.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: d.kovalenko@postgrespro.ru
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18960: Mistake in test test_simple_pipeline (libpq_pipeline.c)
Date: Wed, 3 Sep 2025 14:28:30 +0200
Message-ID: <202509031228.wuh3frddxcvl@alvherre.pgsql> (raw)
In-Reply-To: <2790652.1750536063@sss.pgh.pa.us>
On 2025-Jun-21, Tom Lane wrote:
> Here's a shot at improving matters. I also made an effort
> at cleaning up memory leaks in libpq_pipeline.c, although
> that's surely neatnik-ism not anything meaningful.
Yeah, the code looks much better this way. I thought it was a bit odd
that a function called confirm_result_status() would actually consume
said status. Would it be better as
consume_result_status(PGconn *conn, ExecStatusType expected)
?
I think the patch is a clear improvement regardless.
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
"World domination is proceeding according to plan" (Andrew Morton)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: alvherre@kurilemu.de, tgl@sss.pgh.pa.us, d.kovalenko@postgrespro.ru, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18960: Mistake in test test_simple_pipeline (libpq_pipeline.c)
In-Reply-To: <202509031228.wuh3frddxcvl@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox