pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: Amit Langote <amitlangote09@gmail.com>
Cc: sbernikov@gmail.com, PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #17055: Logical replication worker crashes when applying update of row that dose not exist in target partiti
Date: Fri, 11 Jun 2021 21:37:05 -0400
Message-ID: <2139835.1623461825@sss.pgh.pa.us> (raw)
In-Reply-To: <YMQOd4RvCq1ui19U@paquier.xyz>
References: <1828113.1623370641@sss.pgh.pa.us>
	<CA+HiwqG05LNWKv=fJDtF93LFmA99KCSZtnAJUAsjBOLFOPy-fA@mail.gmail.com>
	<YMMCFPuQwO6sEcJ+@paquier.xyz>
	<CA+HiwqF0xi2KmPYKPPCtcgQ2vnjQrfm5cdY50VRC+S_s1M4KvQ@mail.gmail.com>
	<1881335.1623423667@sss.pgh.pa.us>
	<2058966.1623442520@sss.pgh.pa.us>
	<YMP+Gx2S8meYYHW4@paquier.xyz>
	<2136546.1623457890@sss.pgh.pa.us>
	<YMQEO1EYRQX1cWGQ@paquier.xyz>
	<2138662.1623460441@sss.pgh.pa.us>
	<YMQOd4RvCq1ui19U@paquier.xyz>

Michael Paquier <michael@paquier.xyz> writes:
> Still, the current style is not a pattern I think we should spread
> around, as a lot of copy-paste gets done in new tests added and one
> would easily mix up queries with pattern checks.  The practice I'd
> like to encourage is something like the attached, to make clear that
> there is no risk to fetch incorrect logs.

If you prefer.  However, I'd note that this patch as it stands
sort of breaks the argument I just made, as now you are interrogating
the postmaster's state after sending SIGHUP and before doing anything
that will wait for that to take effect.  I think you should move the
location-capture commands down by at least one safe_psql call.

			regards, tom lane





view thread (17+ messages)  latest in thread

Message-ID: <2139835.1623461825@sss.pgh.pa.us>
Permalink:  ../2139835.1623461825@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/2139835.1623461825@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, michael@paquier.xyz, amitlangote09@gmail.com, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #17055: Logical replication worker crashes when applying update of row that dose not exist in target partiti
  In-Reply-To: <2139835.1623461825@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox