pg.ddx.io pgsql-bugs@postgresql.org mailing list archive help / color / mirror / Atom feed From: Tom Lane <tgl@sss.pgh.pa.us>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Noah Misch <noah@leadboat.com>
Cc: Adam, Etienne (Nokia-TECH/Issy Les Moulineaux) <etienne.adam@nokia.com>
Cc: PostgreSQL Bugs <pgsql-bugs@postgresql.org>
Cc: Duquesne, Pierre (Nokia-TECH/Issy Les Moulineaux) <pierre.duquesne@nokia.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: [HACKERS] [postgresql 10 beta3] unrecognized node type: 90
Date: Wed, 30 Aug 2017 07:39:34 -0400
Message-ID: <23961.1504093174@sss.pgh.pa.us> (raw )
In-Reply-To: <CAA4eK1KVGf1aeTKThtLAKse2EZ75uhzj3zE6Syd3CxeUMFCPZg@mail.gmail.com >
References: <CAL7LBcYM-32B=n_-h_wPHWiML26UvqP3b_WxD7MgXgOwmxvTFw@mail.gmail.com >
<11673.1502467154@sss.pgh.pa.us >
<20170815025243.GA3986579@rfd.leadboat.com >
<CAA4eK1KeQWZOoDmDmGMwuqzPW9JhRS+ditQVFdAfGjNmMZzqMQ@mail.gmail.com >
<CA+TgmoaWPtfdcZjg+dqLephgKaG7kF8DEdvB870A2t4cUh5x+Q@mail.gmail.com >
<26053.1502804769@sss.pgh.pa.us >
<CAA4eK1J_dRv+pGt2bquwmwd_K9+Nght2=tbAc3uUzCinJTMmLg@mail.gmail.com >
<2941.1502979564@sss.pgh.pa.us >
<CAA4eK1KeGhogrkO1JWo=WnvEHm_i9tz6-Gt65zELB1hi=P28Hw@mail.gmail.com >
<CAA4eK1+qD0yfh-iNDKrM7=qMxPOd2KkCZRTX+uxYsDMn0RBwUQ@mail.gmail.com >
<28782.1502992247@sss.pgh.pa.us >
<29467.1502993219@sss.pgh.pa.us >
<CA+Tgmob+S=c=wqaJXNgKT2VhhAVRYFz=MagoTDWb0MueM1xBxg@mail.gmail.com >
<18650.1502995942@sss.pgh.pa.us >
<1105.1503008416@sss.pgh.pa.us >
<24667.1503865781@sss.pgh.pa.us >
<CAA4eK1LqHdSL0nH04EJ79AnUeKCHPf-rpgkrYszYpKETVFM-Wg@mail.gmail.com >
<3924.1503923486@sss.pgh.pa.us >
<CAA4eK1+eEZ5+4jMdWtGtAGK9kDHDcH7Q_xNSxXZV_0wwhTPbZQ@mail.gmail.com >
<CA+Tgmob-jDKc8DUT! zsCsQEmX7JNqHQC9u3=059WaO95YLwoaAA@mail.gmail.com >
<300.1503959717@sss.pgh.pa.us >
<CA+TgmoYnszKkA9ibeRV0fTOT2f9h6ROE5Cf_DZLXEtCpiEF9Tg@mail.gmail.com >
<9314.1503973040@sss.pgh.pa.us >
<CA+TgmoZYQJyFEr3hCZcagbVTnniMPBQ6S-su26m_GHEjBA45+A@mail.gmail.com >
<CAA4eK1J9c=tXsVGM6w3iSLqU1G2L9=fyACCSypzLTO0eo6TSJg@mail.gmail.com >
<9861.1504024543@sss.pgh.pa.us >
<CAA4eK1KVGf1aeTKThtLAKse2EZ75uhzj3zE6Syd3CxeUMFCPZg@mail.gmail.com >
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-bugs>
Amit Kapila <amit.kapila16@gmail.com> writes:
> On Tue, Aug 29, 2017 at 10:05 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> ! /* Make sure any existing workers are gracefully shut down */
> ExecShutdownGatherWorkers(node);
> The above call doesn't ensure the shutdown. It just ensures that we
> receive all messages from parallel workers. Basically, it doesn't
> call WaitForParallelWorkersToExit.
Perhaps you should submit a patch to rename ExecShutdownGatherWorkers
to something less misleading, then. But the previous comment there
was even more wrong :-(
regards, tom lane
--
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs
view thread (44+ messages) latest in thread
Message-ID: <23961.1504093174@sss.pgh.pa.us>
Permalink: ../23961.1504093174@sss.pgh.pa.us/
Also on: postgresql.org/message-id/23961.1504093174@sss.pgh.pa.us
copy link · copy postgr.es
reply Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, amit.kapila16@gmail.com, robertmhaas@gmail.com, noah@leadboat.com, etienne.adam@nokia.com, pierre.duquesne@nokia.com, pgsql-hackers@postgresql.org
Subject: Re: [HACKERS] [postgresql 10 beta3] unrecognized node type: 90
In-Reply-To: <23961.1504093174@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox