From: Tom Lane <tgl@sss.pgh.pa.us>
To: Bruce Momjian <bruce@momjian.us>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Gavin Flower <GavinFlower@archidevsys.co.nz>
Cc: Noah Misch <noah@leadboat.com>
Cc: neverov.max@gmail.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16939: Plural interval for negative singular
Date: Tue, 27 Apr 2021 23:43:10 -0400
Message-ID: <2761425.1619581390@sss.pgh.pa.us> (raw)
In-Reply-To: <2753264.1619568545@sss.pgh.pa.us>
References: <20210427234438.GA22943@alvherre.pgsql>
<2753264.1619568545@sss.pgh.pa.us>
I wrote:
> Hm. We actually document PQprint. While the other two entry points
> in that file aren't documented, they are listed in exports.txt,
> which means somebody *could* be calling them. I think we'd at least
> have to go through a long deprecation period before we could consider
> removing them.
Meanwhile, returning to the point at hand in this thread: AFAICS
from a quick review of the git logs, the last intentional changes
of user-visible behavior in fe-print.c were more than 20 years ago.
Since then it's only seen in-passing bug fixes, such as libpq-wide
fixes of signal handling.
So, to the extent that this code has any use at all it's for
legacy applications. I don't think we should be making random
changes in its behavior for at-best-weak reasons.
In short, I'm now a vote to revert every single bit of 5da9868ed.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, bruce@momjian.us, alvherre@alvh.no-ip.org, GavinFlower@archidevsys.co.nz, noah@leadboat.com, neverov.max@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16939: Plural interval for negative singular
In-Reply-To: <2761425.1619581390@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox