pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Neil Chen <carpenter.nail.cz@gmail.com>
Cc: Bossart, Nathan <bossartn@amazon.com>
Cc: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Boris P. Korzun <drtr0jan@yandex.ru>
Cc: pgsql-bugs@lists.postgresql.org <pgsql-bugs@lists.postgresql.org>
Subject: Re: Inconsistent behavior of pg_dump/pg_restore on DEFAULT PRIVILEGES
Date: Fri, 22 Oct 2021 15:26:49 -0400
Message-ID: <2818927.1634930809@sss.pgh.pa.us> (raw)
In-Reply-To: <2008944.1634680714@sss.pgh.pa.us>
References: <CAA3qoJnr2+1dVJObNtfec=qW4Z0nz=A9+r5bZKoTSy5RDjskMw@mail.gmail.com>
	<8261632200581@mail.yandex.ru>
	<CAA3qoJ=f6jZAkkfwH+rtH_8C9z-nfcgNFYZnGYxVdBjz7Vkhig@mail.gmail.com>
	<CAD21AoBrCbjiJt3OCDQCLrM6OQOxjV9cAyM6bn4=SjHq0konBQ@mail.gmail.com>
	<CAD21AoC+m46JEsFE2d6JQuPuNN5ODj1vpZ3z2HtPdn+HFDJfdg@mail.gmail.com>
	<721942.1634180151@sss.pgh.pa.us>
	<CAD21AoAUCNCo77LJLAFGEkhtgruMpzPD153SC7dY7TyahvM_Fg@mail.gmail.com>
	<YWfh9O/36r+GlgNB@paquier.xyz>
	<CAD21AoDRg1E7AEM_5ifyjFbQ71J303OHA-R1HjzqC0FT306dKQ@mail.gmail.com>
	<AB89F451-ED7F-4FA6-ADF8-F8132220D6A2@amazon.com>
	<CAD21AoArNPsNKYE1b-oURYonUA7Zo-kaq-u661uWcZqTURb48A@mail.gmail.com>
	<1737876.1634613552@sss.pgh.pa.us>
	<CAD21AoC5qNd8psDS4x792DCeuC3xcBmq6Bjrkj8_P1sAscJz4Q@mail.gmail.com>
	<1951182.1634673234@sss.pgh.pa.us>
	<2C411167-8492-497B-A110-81E7081B1B0E@amazon.com>
	<2008944.1634680714@sss.pgh.pa.us>

I wrote:
> [ pokes at it some more... ]  Yeah, I just didn't have my head screwed
> on straight.  We need the global entries to be dumped as deltas from
> the proper object-type-specific ACL, while the non-global ones should be
> dumped as grants only, which can be modeled as a delta from an empty
> ACL.  So the patch should be good as given (though maybe the comment
> needs more work to clarify this).  Sorry for the noise.

This was blocking some other work I'm doing on pg_dump, so I rewrote
the comment some more and pushed it.

			regards, tom lane





view thread (26+ messages)  latest in thread

Message-ID: <2818927.1634930809@sss.pgh.pa.us>
Permalink:  ../2818927.1634930809@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/2818927.1634930809@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, carpenter.nail.cz@gmail.com, bossartn@amazon.com, sawada.mshk@gmail.com, michael@paquier.xyz, drtr0jan@yandex.ru, pgsql-bugs@lists.postgresql.org
  Subject: Re: Inconsistent behavior of pg_dump/pg_restore on DEFAULT PRIVILEGES
  In-Reply-To: <2818927.1634930809@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox