pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Alexander Lakhin <exclusion@gmail.com>
To: Tender Wang <tndrwang@gmail.com>
Cc: Richard Guo <guofenglinux@gmail.com>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18297: Error when adding a column to a parent table with complex inheritance
Date: Mon, 22 Jan 2024 20:00:01 +0300
Message-ID: <2f37c3f3-4701-5efd-c007-2b1cc310a93a@gmail.com> (raw)
In-Reply-To: <CAHewXNnx5t1ODMY1fw1ajCLHkfUd4o9sARX2c+rSGjUUbmo4uQ@mail.gmail.com>
References: <18297-b04cd83a55b51e35@postgresql.org>
	<CAHewXNkjMSzka_sGjtSysDRZpG93j5a=8ebq6f3Gcuo-xAGygw@mail.gmail.com>
	<CAMbWs48DPeuusHFaZ8xk=ag6TbhfqtF9KUEUMmb3nY7zPYCBdA@mail.gmail.com>
	<CAHewXNnhOgY4jTHKa2F1zJdtxUECmEMzV_VANnCNTuL3+_Bx6A@mail.gmail.com>
	<38de09cc-70f3-28ee-fe67-ae13cba23e61@gmail.com>
	<CAHewXN=dPJDvaoME0G9vyemUmY-TpDuqQfcHJRWfUvSWX1p=rQ@mail.gmail.com>
	<9481c16e-8477-eb73-4e20-91bb1a13e2e0@gmail.com>
	<CAHewXNnx5t1ODMY1fw1ajCLHkfUd4o9sARX2c+rSGjUUbmo4uQ@mail.gmail.com>

Hi,

22.01.2024 13:36, Tender Wang wrote:
>
>     Yes, I've encountered a similar issue, this time with ALTER (TEXT SEARCH
>     CONFIGURATION):
>     CREATE TEXT SEARCH CONFIGURATION ispell_tst (COPY=english);
>     CREATE TEXT SEARCH DICTIONARY ispell (Template=ispell, DictFile=ispell_sample, AffFile=ispell_sample);
>     ALTER TEXT SEARCH CONFIGURATION ispell_tst ALTER MAPPING FOR word, word WITH ispell;
>     ERROR:  tuple already updated by self
>
>
> Yes, this is another issue that DDL operation on an same object twice. Maybe we can report error on Parse phase.
> But as you say, all the other DDL commands run OK, so maybe it's better to process this case in execution phase.
> I will send a patch later.

Thank you for working on this!

As these two cases look like exceptions to the common behavior, I wonder
whether we need some extra functions to deal with duplicates.
(I haven't look yet how such duplicates processed for other object types.)

>
> And I'm just curious that how do you find these issues? Use some tools?

I discovered these two issues with my kind of fuzzer, just watching out
for the interesting errors.

Best regards,
Alexander

view thread (12+ messages)  latest in thread

Message-ID: <2f37c3f3-4701-5efd-c007-2b1cc310a93a@gmail.com>
Permalink:  ../2f37c3f3-4701-5efd-c007-2b1cc310a93a@gmail.com/
Also on:    postgresql.org/message-id/2f37c3f3-4701-5efd-c007-2b1cc310a93a@gmail.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: exclusion@gmail.com, tndrwang@gmail.com, guofenglinux@gmail.com, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #18297: Error when adding a column to a parent table with complex inheritance
  In-Reply-To: <2f37c3f3-4701-5efd-c007-2b1cc310a93a@gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox