pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Tender Wang <tndrwang@gmail.com>
Cc: Alexander Lakhin <exclusion@gmail.com>
Cc: Richard Guo <guofenglinux@gmail.com>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18297: Error when adding a column to a parent table with complex inheritance
Date: Wed, 24 Jan 2024 15:20:42 +0900
Message-ID: <ZbCsOi3HBPAkwN83@paquier.xyz> (raw)
In-Reply-To: <CAHewXNkf7Th5-5F_fgWcAb88jOJx=K03J=P17cLjfEMM2BQahA@mail.gmail.com>
References: <18297-b04cd83a55b51e35@postgresql.org>
	<CAHewXNkjMSzka_sGjtSysDRZpG93j5a=8ebq6f3Gcuo-xAGygw@mail.gmail.com>
	<CAMbWs48DPeuusHFaZ8xk=ag6TbhfqtF9KUEUMmb3nY7zPYCBdA@mail.gmail.com>
	<CAHewXNnhOgY4jTHKa2F1zJdtxUECmEMzV_VANnCNTuL3+_Bx6A@mail.gmail.com>
	<38de09cc-70f3-28ee-fe67-ae13cba23e61@gmail.com>
	<CAHewXN=dPJDvaoME0G9vyemUmY-TpDuqQfcHJRWfUvSWX1p=rQ@mail.gmail.com>
	<9481c16e-8477-eb73-4e20-91bb1a13e2e0@gmail.com>
	<CAHewXNnx5t1ODMY1fw1ajCLHkfUd4o9sARX2c+rSGjUUbmo4uQ@mail.gmail.com>
	<2f37c3f3-4701-5efd-c007-2b1cc310a93a@gmail.com>
	<CAHewXNkf7Th5-5F_fgWcAb88jOJx=K03J=P17cLjfEMM2BQahA@mail.gmail.com>

On Tue, Jan 23, 2024 at 11:19:57AM +0800, Tender Wang wrote:
> Your reported two issues have different code path, and duplicates do not
> processed.
> 
> I am considering whether there is a unified way of handling this, otherwise
> each one will have to be dealt with separately.

Yes, I don't agree with what you have posted on [1], inventing a new
way to handle what is basically a way to remove duplicated
ObjectAddresses, and that's what we use in the DropRole() path.

The problem reported on this thread has now been fixed as of
bb812ab0917e, so why not moving the rest to a different thread with a
proper subject?  This will attract a better audience for the topic
dealt with.

[1]: https://www.postgresql.org/message-id/CAHewXN=dPJDvaoME0G9vyemUmY-TpDuqQfcHJRWfUvSWX1p=rQ@mail.gmail...
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (12+ messages)

Message-ID: <ZbCsOi3HBPAkwN83@paquier.xyz>
Permalink:  ../ZbCsOi3HBPAkwN83@paquier.xyz/
Also on:    postgresql.org/message-id/ZbCsOi3HBPAkwN83@paquier.xyz

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: michael@paquier.xyz, tndrwang@gmail.com, exclusion@gmail.com, guofenglinux@gmail.com, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #18297: Error when adding a column to a parent table with complex inheritance
  In-Reply-To: <ZbCsOi3HBPAkwN83@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox