From: Zhijie Hou <houzhijie22@gmail.com>
To: Kirill Reshke <reshkekirill@gmail.com>
To: Hayato Kuroda (Fujitsu) <kuroda.hayato@fujitsu.com>
Cc: brar@gmx.de <brar@gmx.de>
Cc: pgsql-bugs@lists.postgresql.org <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #19795: pgoutput: walsender crashes on START_REPLICATION option without a value
Date: Sat, 31 Oct 2026 19:31:20 +0800
Message-ID: <34348588-9b17-4b9b-a069-11f106cdc32a@gmail.com> (raw)
In-Reply-To: <CALdSSPgUUY0B5dVWomzZRGvkvHqyyyF8xdAm=0N+RizPuSWZkQ@mail.gmail.com>
References: <19795-6d7d506133b7f062@postgresql.org>
<CAFvd2n-BDb2rp+8jKyUrf-Uv4YgZqDa+O0gzt_JDfCpC-9gGxA@mail.gmail.com>
<OS7PR01MB18317FEB9D24DE47C5077EF90F5612@OS7PR01MB18317.jpnprd01.prod.outlook.com>
<CALdSSPgUUY0B5dVWomzZRGvkvHqyyyF8xdAm=0N+RizPuSWZkQ@mail.gmail.com>
Hi,
On Wed, Oct 28, 2026 at 01:36 AM Kirill Reshke wrote:
> Looks like a real issue. I reviewed a patch, I think this is a natural
> follow-up for [0]. the CREATE_REPLICATION_SLOT/ALTER_REPLICATION_SLOT
> option parser only uses defGetString/defGetBoolean - pgoutput is the
> only crasher.
>
> Also, should we reject option like
>
> ereport(ERROR,
> (errcode(ERRCODE_INVALID_PARAMETER_VALUE),
> errmsg("option \"%s\" requires a value",
> "publication_names")));
>
>
> instead of a generic error message from defGetString?
I think a special message is unnecessary here, especially since we don't
do that in other replication parsing code, so I've kept the current version.
--
Best Regards,
Zhijie Hou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-bugs@postgresql.org
Cc: houzhijie22@gmail.com, reshkekirill@gmail.com, kuroda.hayato@fujitsu.com, brar@gmx.de
Subject: Re: BUG #19795: pgoutput: walsender crashes on START_REPLICATION option without a value
In-Reply-To: <34348588-9b17-4b9b-a069-11f106cdc32a@gmail.com>
References: <19795-6d7d506133b7f062@postgresql.org> <CAFvd2n-BDb2rp+8jKyUrf-Uv4YgZqDa+O0gzt_JDfCpC-9gGxA@mail.gmail.com> <OS7PR01MB18317FEB9D24DE47C5077EF90F5612@OS7PR01MB18317.jpnprd01.prod.outlook.com> <CALdSSPgUUY0B5dVWomzZRGvkvHqyyyF8xdAm=0N+RizPuSWZkQ@mail.gmail.com> <34348588-9b17-4b9b-a069-11f106cdc32a@gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox