From: Tom Lane <tgl@sss.pgh.pa.us>
To: David Rowley <dgrowleyml@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Richard Guo <guofenglinux@gmail.com>
Cc: 甄明洋 <zhenmingyang@yeah.net>
Cc: pgsql-bugs@postgresql.org
Subject: Re: A structure has changed but comment modifications maybe missed
Date: Wed, 29 Mar 2023 22:02:09 -0400
Message-ID: <4119644.1680141729@sss.pgh.pa.us> (raw)
In-Reply-To: <CAApHDvpS1veLtizEvUiQyhcP-uR7=7gnaDn1kPW3pPbeX95X1A@mail.gmail.com>
References: <1a96696c.9d3.187193989c3.Coremail.zhenmingyang@yeah.net>
<CAMbWs4817qLtBLNOM51VH=+tbkU42v4VaP_AgvMjurF_vO2-Cw@mail.gmail.com>
<CAMbWs4_OwkHKO+21z=KF1tdObzoozqcD2r+UM81gmNihQfnj0w@mail.gmail.com>
<CAApHDvpS1veLtizEvUiQyhcP-uR7=7gnaDn1kPW3pPbeX95X1A@mail.gmail.com>
David Rowley <dgrowleyml@gmail.com> writes:
> I think the attached is what you have in mind. Can you confirm?
tts_nvalid is still a thing, so I question your edit here:
inline patch 1: src/include/executor/tuptable.h (+1/-2 lines) download inline-1.patch--- a/src/include/executor/tuptable.h+++ b/src/include/executor/tuptable.h@@ -68,8 +68,7 @@
* A TupleTableSlot can also be "empty", indicated by flag TTS_FLAG_EMPTY set
* in tts_flags, holding no valid data. This is the only valid state for a
* freshly-created slot that has not yet had a tuple descriptor assigned to
- * it. In this state, TTS_SHOULDFREE should not be set in tts_flags, tts_tuple- * must be NULL and tts_nvalid zero.+ * it. In this state, TTS_FLAG_SHOULDFREE should not be set in tts_flags.
*
* The tupleDescriptor is simply referenced, not copied, by the TupleTableSlot
* code. The caller of ExecSetSlotDescriptor() is responsible for providing
Andres would really be the expert about these changes though.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, dgrowleyml@gmail.com, andres@anarazel.de, guofenglinux@gmail.com, zhenmingyang@yeah.net
Subject: Re: A structure has changed but comment modifications maybe missed
In-Reply-To: <4119644.1680141729@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox