From: Tom Lane <tgl@sss.pgh.pa.us>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Jacob Champion <jchampion@timescale.com>
Cc: heath.lord@crunchydata.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17625: In PG15 PQsslAttribute returns different values than PG14 when SSL is not in use for the connection
Date: Thu, 29 Sep 2022 17:29:14 -0400
Message-ID: <432064.1664486954@sss.pgh.pa.us> (raw)
In-Reply-To: <B9EC60EC-F665-47E8-A221-398C76E382C9@yesql.se>
References: <17625-fc47c78b7d71b534@postgresql.org>
<346263.1664480998@sss.pgh.pa.us>
<360379.1664482591@sss.pgh.pa.us>
<CAAWbhmhYNOubS2qTx3rG8V2STZ9F0SrtRBuPJimCwRYAQ6r3BQ@mail.gmail.com>
<395956.1664484332@sss.pgh.pa.us>
<B9EC60EC-F665-47E8-A221-398C76E382C9@yesql.se>
Daniel Gustafsson <daniel@yesql.se> writes:
> Reading a few lines further down in the docs I noticed this description for the
> compression parameter to PQsslAttribute:
> "If SSL compression is in use, returns the name of the compression
> algorithm, or "on" if compression is used but the algorithm is not
> known. If compression is not in use, returns "off"."
> AFAICT that has never been the case since 91fa7b4719ac, it has always just
> returned "on" or "off" and never the name of the compression algorithm. I
> propose to apply the attached backpatched to make the docs align with the code.
Yeah, it clearly doesn't do that. +1
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, daniel@yesql.se, jchampion@timescale.com, heath.lord@crunchydata.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17625: In PG15 PQsslAttribute returns different values than PG14 when SSL is not in use for the connection
In-Reply-To: <432064.1664486954@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox