From: Alexander Lakhin <exclusion@gmail.com>
To: Daniel Gustafsson <daniel@yesql.se>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: king tomo <t.katsumata1122@gmail.com>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18224: message bug in libpqwalreceiver.c.
Date: Sun, 10 Dec 2023 07:00:00 +0300
Message-ID: <68138521-5345-8780-4390-1474afdcba1f@gmail.com> (raw)
In-Reply-To: <9C3157E9-C42D-40E3-9A11-64E4F890CD4E@yesql.se>
References: <18224-59c34f71e2c6a5ed@postgresql.org>
<CAC55fYeoBvYSyRupWEP+BzGwhdi7R7nvPffM7QhQyqDcpedxig@mail.gmail.com>
<C35E2C78-AA74-4115-8A25-A3D425349604@yesql.se>
<750771.1701698849@sss.pgh.pa.us>
<A44077E7-8D36-470A-A1AC-C560DEA26E6E@yesql.se>
<751760.1701699492@sss.pgh.pa.us>
<9C3157E9-C42D-40E3-9A11-64E4F890CD4E@yesql.se>
Hello Daniel,
05.12.2023 16:44, Daniel Gustafsson wrote:
> Following the bouncing ball it turns out that restricting to 9.4+ (effectively
> reapplying 083d29c65b78 adapted to the callsites moved to a common function)
> across the board isn't doable since pg_basebackup requires IDENTIFY_SYSTEM for
> 9.1->9.3 to get the starttli. Thus I opted for just fixing the error message
> and left the restriction on 9.4+ as future work for when it can be done across
> all callers.
Isn't IDENTIFY_SERVER a mistake in the comment added?:
+ * IDENTIFY_SERVER returns 3 columns in 9.3 and earlier, and 4 columns in
+ * 9.4 and onwards.
Best regards,
Alexander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: exclusion@gmail.com, daniel@yesql.se, tgl@sss.pgh.pa.us, t.katsumata1122@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18224: message bug in libpqwalreceiver.c.
In-Reply-To: <68138521-5345-8780-4390-1474afdcba1f@gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox