From: Tom Lane <tgl@sss.pgh.pa.us>
To: Ranier Vilela <ranier.vf@gmail.com>
Cc: Laurenz Albe <laurenz.albe@cybertec.at>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: printf %s with NULL pointer (was Re: BUG #17098: Assert failed on composing an error message when adding a type to an extension being dropped)
Date: Tue, 13 Jul 2021 14:26:18 -0400
Message-ID: <3280448.1626200778@sss.pgh.pa.us> (raw)
In-Reply-To: <CAEudQAq22dUhHp9ryKNOnro0HkQWiJE1F3g3VxHUFsqQ4ZkyeA@mail.gmail.com>
References: <17098-b960f3616c861f83@postgresql.org>
<2468663.1626017338@sss.pgh.pa.us>
<2984422.1626110456@sss.pgh.pa.us>
<dc29b1131b84bef879cf68d1d1edae07f51ca3d2.camel@cybertec.at>
<3227956.1626186568@sss.pgh.pa.us>
<CAEudQAq22dUhHp9ryKNOnro0HkQWiJE1F3g3VxHUFsqQ4ZkyeA@mail.gmail.com>
Ranier Vilela <ranier.vf@gmail.com> writes:
> Em ter., 13 de jul. de 2021 às 11:29, Tom Lane <tgl@sss.pgh.pa.us> escreveu:
>> I think you're missing my main point, which is that it seems certain that
>> there are corner cases that do this *now*. I'm proposing that we redefine
>> this as not being a crash case, full stop.
> I agree with Laurenz Albe, that on Debug builds, *printf with NULL, must
> crash.
Did you see my followup? The vast majority of live systems do not do
that, so we are accomplishing nothing of value by insisting it's a
crash-worthy bug.
I flat out don't agree that "crash on debug builds but it's okay on
production" is a useful way to define this. I spend way too much
time already on bug reports that only manifest with asserts enabled.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, ranier.vf@gmail.com, laurenz.albe@cybertec.at, pgsql-hackers@lists.postgresql.org
Subject: Re: printf %s with NULL pointer (was Re: BUG #17098: Assert failed on composing an error message when adding a type to an extension being dropped)
In-Reply-To: <3280448.1626200778@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox