pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Andrew Dunstan <andrew@dunslane.net>
To: Justin Pryzby <pryzby@telsasoft.com>
To: Jacob Champion <pchampion@vmware.com>
Cc: tgl@sss.pgh.pa.us
Cc: peter.eisentraut@enterprisedb.com
Cc: pgsql-hackers@lists.postgresql.org
Cc: buschmann@nidsa.net
Cc: noah@leadboat.com
Cc: tomas.vondra@2ndquadrant.com
Cc: bruce@momjian.us
Cc: andres@anarazel.de
Subject: Re: pg_upgrade test for binary compatibility of core data types
Date: Fri, 24 Sep 2021 10:58:52 -0400
Message-ID: <83220c96-c2dd-fa42-ccc6-67dc0d848312@dunslane.net> (raw)
In-Reply-To: <5d72f199-dc11-89a8-29d1-f20f9687c86f@dunslane.net>
References: <be693563-def1-2f5a-89c1-f4d3cb2ae716@enterprisedb.com>
	<20210112041352.GY1849@telsasoft.com>
	<20210112171559.GO4320@momjian.us>
	<20210112172753.GC1849@telsasoft.com>
	<20210112175356.GP4320@momjian.us>
	<66753439-83ae-7be5-6e41-9537a6041a39@dunslane.net>
	<d9f14840-9f6e-183d-f43a-9f9b9e1b6d19@enterprisedb.com>
	<1575064.1615060903@sss.pgh.pa.us>
	<20210430183348.GQ27406@telsasoft.com>
	<a31d593da98da15fc2302a16b3f3b32e491d3e49.camel@vmware.com>
	<20210912005116.GF26465@telsasoft.com>
	<30b2e19c-b44d-ec0a-6ea6-789b8e2be004@dunslane.net>
	<ea3a2e19-4266-6be1-d5dc-497f3c0ce543@dunslane.net>
	<5d72f199-dc11-89a8-29d1-f20f9687c86f@dunslane.net>


On 9/15/21 3:28 PM, Andrew Dunstan wrote:
> On 9/13/21 9:20 AM, Andrew Dunstan wrote:
>> On 9/12/21 2:41 PM, Andrew Dunstan wrote:
>>> On 9/11/21 8:51 PM, Justin Pryzby wrote:
>>>> @Andrew: did you have any comment on this part ?
>>>>
>>>> |Subject: buildfarm xversion diff
>>>> |Forking https://www.postgresql.org/message-id/20210328231433.GI15100@telsasoft.com
>>>> |
>>>> |I gave suggestion how to reduce the "lines of diff" metric almost to nothing,
>>>> |allowing a very small "fudge factor", and which I think makes this a pretty
>>>> |good metric rather than a passable one.
>>>>
>>> Somehow I missed that. Looks like some good suggestions. I'll
>>> experiment. (Note: we can't assume the presence of sed, especially on
>>> Windows).
>>>
>>>
>> I tried with the attached patch on crake, which tests back as far as
>> 9.2. Here are the diff counts from HEAD:
>>
>>
>> andrew@emma:HEAD $ grep -c '^[+-]' dumpdiff-REL9_* dumpdiff-REL_1*
>> dumpdiff-HEAD
>> dumpdiff-REL9_2_STABLE:514
>> dumpdiff-REL9_3_STABLE:169
>> dumpdiff-REL9_4_STABLE:185
>> dumpdiff-REL9_5_STABLE:221
>> dumpdiff-REL9_6_STABLE:11
>> dumpdiff-REL_10_STABLE:11
>> dumpdiff-REL_11_STABLE:73
>> dumpdiff-REL_12_STABLE:73
>> dumpdiff-REL_13_STABLE:73
>> dumpdiff-REL_14_STABLE:0
>> dumpdiff-HEAD:0
>>
>>
>> I've also attached those non-empty dumpdiff files for information, since
>> they are quite small.
>>
>>
>> There is still work to do, but this is promising. Next step: try it on
>> Windows.
>>
>>
> It appears to do the right thing on Windows. yay!
>
>
> We probably need to get smarter about the heuristics, though, e.g. by
> taking into account the buildfarm options and the platform. It would
> also help a lot if we could make vcregress.pl honor USE_MODULE_DB.
> That's on my TODO list, but it just got a lot higher priority.
>
>


Here's what I've committed:
<https://github.com/PGBuildFarm/client-code/commit/6317d82c0e897a29dabd57ed8159d13920401f96;


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com






view thread (36+ messages)  latest in thread

Message-ID: <83220c96-c2dd-fa42-ccc6-67dc0d848312@dunslane.net>
Permalink:  ../83220c96-c2dd-fa42-ccc6-67dc0d848312@dunslane.net/
Also on:    postgresql.org/message-id/83220c96-c2dd-fa42-ccc6-67dc0d848312@dunslane.net

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: andrew@dunslane.net, pryzby@telsasoft.com, pchampion@vmware.com, tgl@sss.pgh.pa.us, peter.eisentraut@enterprisedb.com, pgsql-hackers@lists.postgresql.org, buschmann@nidsa.net, noah@leadboat.com, tomas.vondra@2ndquadrant.com, bruce@momjian.us, andres@anarazel.de
  Subject: Re: pg_upgrade test for binary compatibility of core data types
  In-Reply-To: <83220c96-c2dd-fa42-ccc6-67dc0d848312@dunslane.net>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox