From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Justin Pryzby <pryzby@telsasoft.com>
To: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andres Freund <andres@anarazel.de>
Cc: buschmann@nidsa.net
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: pg_upgrade test for binary compatibility of core data types
Date: Mon, 11 Jan 2021 15:28:08 +0100
Message-ID: <be693563-def1-2f5a-89c1-f4d3cb2ae716@enterprisedb.com> (raw)
In-Reply-To: <20201227190729.GB26311@telsasoft.com>
References: <20191013001032.lqrn4kqaovhrf77l@development>
<17717.1570991208@sss.pgh.pa.us>
<20191013203848.2eksimmpux3546wr@development>
<27596.1571062600@sss.pgh.pa.us>
<20191014163538.cqn6j4cl7s2mk2yz@development>
<20191015001817.zei45apgpu5dzngr@development>
<20191015044118.GO3599@telsasoft.com>
<20191015070725.csmdmdvrlb6klwkg@development>
<20201206180248.GI24052@telsasoft.com>
<20201216172222.GS30237@telsasoft.com>
<20201227190729.GB26311@telsasoft.com>
On 2020-12-27 20:07, Justin Pryzby wrote:
> On Wed, Dec 16, 2020 at 11:22:23AM -0600, Justin Pryzby wrote:
>> On Sun, Dec 06, 2020 at 12:02:48PM -0600, Justin Pryzby wrote:
>>> I meant to notice if the binary format is accidentally changed again, which was
>>> what happened here:
>>> 7c15cef86 Base information_schema.sql_identifier domain on name, not varchar.
>>>
>>> I added a table to the regression tests so it's processed by pg_upgrade tests,
>>> run like:
>>>
>>> | time make -C src/bin/pg_upgrade check oldsrc=`pwd`/11 oldbindir=`pwd`/11/tmp_install/usr/local/pgsql/bin
>>
>> Per cfbot, this avoids testing ::xml (support for which may not be enabled)
>> And also now tests oid types.
>>
>> I think the per-version hacks should be grouped by logical change, rather than
>> by version. Which I've started doing here.
>
> rebased on 6df7a9698bb036610c1e8c6d375e1be38cb26d5f
I think these patches could use some in-place documentation of what they
are trying to achieve and how they do it. The required information is
spread over a lengthy thread. No one wants to read that. Add commit
messages to the patches.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: peter.eisentraut@enterprisedb.com, pryzby@telsasoft.com, tomas.vondra@2ndquadrant.com, tgl@sss.pgh.pa.us, andres@anarazel.de, buschmann@nidsa.net, pgsql-hackers@lists.postgresql.org
Subject: Re: pg_upgrade test for binary compatibility of core data types
In-Reply-To: <be693563-def1-2f5a-89c1-f4d3cb2ae716@enterprisedb.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox