From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: Andy Fan <zhihuifan1213@163.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: zoulx1982@163.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16931: source code problem about commit_ts
Date: Wed, 2 Jul 2025 17:44:30 +0900
Message-ID: <873d332a-9609-4a1a-bb01-0344e2542575@oss.nttdata.com> (raw)
In-Reply-To: <87ecuzmkqf.fsf@163.com>
References: <20210409224241.GA32072@alvherre.pgsql>
<a92a5d4f-4167-22fd-2aa4-3642df5cf978@oss.nttdata.com>
<87ecuzmkqf.fsf@163.com>
On 2025/07/02 10:42, Andy Fan wrote:
> Fujii Masao <masao.fujii@oss.nttdata.com> writes:
>
> Hi,
>
>> On 2021/04/10 7:42, Alvaro Herrera wrote:
>>> On 2021-Mar-24, Fujii Masao wrote:
>>>
>>>> diff --git a/src/backend/access/rmgrdesc/committsdesc.c b/src/backend/access/rmgrdesc/committsdesc.c
>>>> index 7ebd3d35ef..26bad44b96 100644
>>>> --- a/src/backend/access/rmgrdesc/committsdesc.c
>>>> +++ b/src/backend/access/rmgrdesc/committsdesc.c
>>>> @@ -38,31 +38,6 @@ commit_ts_desc(StringInfo buf, XLogReaderState *record)
>>>> appendStringInfo(buf, "pageno %d, oldestXid %u",
>>>> trunc->pageno, trunc->oldestXid);
>>>> }
>>>> - else if (info == COMMIT_TS_SETTS)
>>> You have not pushed this one, right? I think we should do it now.
>>
>> Thanks for the ping! Pushed!
>
> Did this commit(08aa89b326261b669648df97d4f2a6edba22d26a) forget to
> remove struct xl_commit_ts_set?
You're right. I seem to have overlooked that.
> After it, there is no reference to
> xl_commit_ts_set. So Is it better clean them as well?
Agreed, the patch looks good to me. Unless there are objections,
I'll go ahead and commit it. While this could be considered an oversight
in the original commit, it's not a bug fix, so I plan to apply it
only to the master branch.
Regards,
--
Fujii Masao
NTT DATA Japan Corporation
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: masao.fujii@oss.nttdata.com, zhihuifan1213@163.com, alvherre@alvh.no-ip.org, zoulx1982@163.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16931: source code problem about commit_ts
In-Reply-To: <873d332a-9609-4a1a-bb01-0344e2542575@oss.nttdata.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox