public inbox for [email protected]  

help / color / mirror / Atom feed
From: VASUKI M <[email protected]>
To: Nazir Bilal Yavuz <[email protected]>
Cc: Michael Paquier <[email protected]>
Cc: Peter Eisentraut <[email protected]>
Cc: Daniel Gustafsson <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: BharatDB <[email protected]>
Cc: [email protected]
Cc: [email protected]
Subject: Re: BUG #19095: Test if function exit() is used fail when linked static
Date: Wed, 18 Feb 2026 09:49:47 +0530
Message-ID: <CACTYHzg=W-D06q2c8jdNi7r9EA+urDVi0zoGTyrY3Q3eA_9P-A@mail.gmail.com> (raw)
In-Reply-To: <CAN55FZ22rrN6gCn7urtmTR=_5z7ArZLUJu-TsMChdXwmRTaquA@mail.gmail.com>
References: <[email protected]>
	<CACTYHzimf5+6gp6HzCerZpWh4o2_TW6-S3k3+2YK5mnoQa-+tg@mail.gmail.com>
	<[email protected]>
	<CACTYHzihgbTyYNQsEGcYmfkPd79r+_Jiz+PhN1xW+3NoJGEhyQ@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<CACTYHzgb=1UXNoW08AjBBUB10dZPoAg4pptFm3K63V5xs=j=Jw@mail.gmail.com>
	<CAN55FZ03oW7zGiCgLfeiRxDQ5NLbyrppP1=mFpQ7QoDkbs84JA@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<CAN55FZ22rrN6gCn7urtmTR=_5z7ArZLUJu-TsMChdXwmRTaquA@mail.gmail.com>

Hi Nazir,

Thank you for pointing this out, and thanks to Andres for the clarification
in the referenced thread.

You are absolutely right — with a stamp file, we need to ensure that its
timestamp is updated unconditionally so that it remains newer than the
inputs. Keeping the existence check (if (! -f ...)) would indeed leave the
stamp file older than the rebuilt library, which can trigger unnecessary
rebuilds in Makefile-based builds.

Although Ninja avoids repeated rebuilds due to its internal tracking, Make
relies purely on timestamps, so the safer and correct behavior is to always
recreate (touch) the stamp file.

The updated implementation without the existence check is therefore the
correct approach.

Regards,
Vasuki M
C-DAC,chennai


view thread (7+ messages)  latest in thread

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: BUG #19095: Test if function exit() is used fail when linked static
  In-Reply-To: <CACTYHzg=W-D06q2c8jdNi7r9EA+urDVi0zoGTyrY3Q3eA_9P-A@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox