From: Oleksii Kliukin <alexk@hintbits.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: pgsql-bugs@lists.postgresql.org, ildus@adjust.com, Chris Travers <chris.travers@adjust.com>
Cc: Nick Babadzhanian <nickb@adjust.com>
Cc: julian.schauder@gmx.de
Subject: Re: postgres crash on concurrent update of inheritance partitioned table
Date: Wed, 29 Jan 2020 10:20:30 +0100
Message-ID: <EDC3F2AC-53D1-407C-82AC-954A700FF059@hintbits.com> (raw)
In-Reply-To: <29583.1580250599@sss.pgh.pa.us>
References: <EEF05F66-2871-4786-992B-5F45C92FEE2E@hintbits.com>
<20200128170755.bq3f27bfkjpt4d4b@development>
<29583.1580250599@sss.pgh.pa.us>
Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Tomas Vondra <tomas.vondra@2ndquadrant.com> writes:
>> On Tue, Jan 28, 2020 at 05:17:14PM +0100, Oleksii Kliukin wrote:
>>> We have experienced a few crashes a day since upgrading to pg 12.1 last
>>> week, during the process of updating an inheritance-partitioned table by
>>> several concurrent sessions.
>
>> Yeah, I can reproduce it too. If I had to guess, I'd say it's another
>> bug due to
>> commit 3fb307bc4a76815f96fec28a0d1525ab3fbbcfb4
>> Author: Andres Freund <andres@anarazel.de>
>> Date: Mon Sep 9 05:21:30 2019 -0700
>> Reorder EPQ work, to fix rowmark related bugs and improve efficiency.
>> which introduced relsubs_done et al, and perhaps did not get the life
>> cycle / resetting right. Not sure.
>
> Yup, that's it exactly. EvalPlanQualStart was expecting to reuse
> relsubs_rowmark and relsubs_done, but that storage will be recycled by
> EvalPlanQualEnd because it's in the query context of the recheckestate.
> AFAICS the re-use has no semantic value, so I just got rid of it.
Sounds good, thank you!
Regards,
Oleksii “Alex” Kliukin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: alexk@hintbits.com, tgl@sss.pgh.pa.us, tomas.vondra@2ndquadrant.com, andres@anarazel.de, chris.travers@adjust.com, nickb@adjust.com, julian.schauder@gmx.de
Subject: Re: postgres crash on concurrent update of inheritance partitioned table
In-Reply-To: <EDC3F2AC-53D1-407C-82AC-954A700FF059@hintbits.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox