From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Amit Langote <amitlangote09@gmail.com>
Cc: sbernikov@gmail.com, PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #17055: Logical replication worker crashes when applying update of row that dose not exist in target partiti
Date: Sat, 12 Jun 2021 10:49:04 +0900
Message-ID: <YMQSkJ+yW1zATYCD@paquier.xyz> (raw)
In-Reply-To: <2139835.1623461825@sss.pgh.pa.us>
References: <YMMCFPuQwO6sEcJ+@paquier.xyz>
<CA+HiwqF0xi2KmPYKPPCtcgQ2vnjQrfm5cdY50VRC+S_s1M4KvQ@mail.gmail.com>
<1881335.1623423667@sss.pgh.pa.us>
<2058966.1623442520@sss.pgh.pa.us>
<YMP+Gx2S8meYYHW4@paquier.xyz>
<2136546.1623457890@sss.pgh.pa.us>
<YMQEO1EYRQX1cWGQ@paquier.xyz>
<2138662.1623460441@sss.pgh.pa.us>
<YMQOd4RvCq1ui19U@paquier.xyz>
<2139835.1623461825@sss.pgh.pa.us>
On Fri, Jun 11, 2021 at 09:37:05PM -0400, Tom Lane wrote:
> If you prefer. However, I'd note that this patch as it stands
> sort of breaks the argument I just made, as now you are interrogating
> the postmaster's state after sending SIGHUP and before doing anything
> that will wait for that to take effect. I think you should move the
> location-capture commands down by at least one safe_psql call.
Ah, right. That would be after "DELETE FROM tab_full_pk" in
001_rep_changes.pl and after "DELETE FROM tab1" in 001_rep_changes.pl
run on the subscribers, then. Would you prefer doing the change? If
you don't think that's not worth it, I won't fight hard on it, but
while we're dealing with it..
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: michael@paquier.xyz, tgl@sss.pgh.pa.us, amitlangote09@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17055: Logical replication worker crashes when applying update of row that dose not exist in target partiti
In-Reply-To: <YMQSkJ+yW1zATYCD@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox