pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Alexander Lakhin <exclusion@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Laurenz Albe <laurenz.albe@cybertec.at>
Cc: rootcause000@gmail.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18146: Rows reappearing in Tables after Auto-Vacuum Failure in PostgreSQL on Windows
Date: Wed, 8 Jan 2025 12:22:41 +0900
Message-ID: <Z33vgfVgvOnbFLN9@paquier.xyz> (raw)
In-Reply-To: <Z329yX7VREL86mnm@paquier.xyz>
References: <ZyCTXqPG_uGvLJtZ@paquier.xyz>
	<CA+TgmobP2AEjS5qzfEVGugfQw1H+7DF283udewzTDPO3-2G-Kg@mail.gmail.com>
	<CA+hUKGJSOEZWx9zRFFfOfDj9zbVmMbWKRq+ZzMCXftHcO1UYQQ@mail.gmail.com>
	<CA+TgmoZj9dJhHQokHioXB8dyDZz5gjzyg7SbUrG=At-uShq7yA@mail.gmail.com>
	<Z2TcN-ypscC4Jomj@paquier.xyz>
	<CA+hUKG+Thae6x6+jmQiuALQBT2Ae1ChjMh1=kMvJ8y_SBJZrvA@mail.gmail.com>
	<CA+hUKGJ4jqhJVTnwiMFbmVonSMn+E9MW3YDZ+JEz9ov_h19RNA@mail.gmail.com>
	<Z2pLwQGNaKq2_JTk@paquier.xyz>
	<CA+hUKGJcBhcUteJ5AcOibq2T24JPxyJFP7GsQ2SaYP-5sA7hNQ@mail.gmail.com>
	<Z329yX7VREL86mnm@paquier.xyz>

On Wed, Jan 08, 2025 at 08:50:33AM +0900, Michael Paquier wrote:
> Sounds good to me.  Thanks for the commit!

Actually not that good, and wrasse is reporting a failure:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=wrasse&dt=2025-01-07%2022%3A26%3A00
"/export/home/nm/farm/studio64v12_6/REL_15_STABLE/pgsql.build/../pgsql/src/backend/storage/smgr/smgr.c",
line 634: void function cannot return value

It seems to me that you meant to do the following in the back
branches:
--- a/src/backend/storage/smgr/smgr.c
+++ b/src/backend/storage/smgr/smgr.c
@@ -706,7 +706,7 @@ smgrtruncate(SMgrRelation reln, ForkNumber *forknum, int nforks,
 	for (int i = 0; i < nforks; ++i)
 		old_nblocks[i] = smgrnblocks(reln, forknum[i]);
 
-	return smgrtruncate2(reln, forknum, nforks, old_nblocks, nblocks);
+	smgrtruncate2(reln, forknum, nforks, old_nblocks, nblocks);
 }
--
Michael

Attachments:

  [application/pgp-signature] signature.asc (832B, ../Z33vgfVgvOnbFLN9@paquier.xyz/2-signature.asc)
  download

view thread (45+ messages)  latest in thread

Message-ID: <Z33vgfVgvOnbFLN9@paquier.xyz>
Permalink:  ../Z33vgfVgvOnbFLN9@paquier.xyz/
Also on:    postgresql.org/message-id/Z33vgfVgvOnbFLN9@paquier.xyz

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: michael@paquier.xyz, thomas.munro@gmail.com, robertmhaas@gmail.com, hlinnaka@iki.fi, exclusion@gmail.com, tgl@sss.pgh.pa.us, laurenz.albe@cybertec.at, rootcause000@gmail.com, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #18146: Rows reappearing in Tables after Auto-Vacuum Failure in PostgreSQL on Windows
  In-Reply-To: <Z33vgfVgvOnbFLN9@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox