From: Michael Paquier <michael@paquier.xyz>
To: Alexander Lakhin <exclusion@gmail.com>
Cc: Tender Wang <tndrwang@gmail.com>
Cc: Richard Guo <guofenglinux@gmail.com>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18297: Error when adding a column to a parent table with complex inheritance
Date: Wed, 24 Jan 2024 15:12:53 +0900
Message-ID: <ZbCqZRvFu2iWHvo4@paquier.xyz> (raw)
In-Reply-To: <38de09cc-70f3-28ee-fe67-ae13cba23e61@gmail.com>
References: <18297-b04cd83a55b51e35@postgresql.org>
<CAHewXNkjMSzka_sGjtSysDRZpG93j5a=8ebq6f3Gcuo-xAGygw@mail.gmail.com>
<CAMbWs48DPeuusHFaZ8xk=ag6TbhfqtF9KUEUMmb3nY7zPYCBdA@mail.gmail.com>
<CAHewXNnhOgY4jTHKa2F1zJdtxUECmEMzV_VANnCNTuL3+_Bx6A@mail.gmail.com>
<38de09cc-70f3-28ee-fe67-ae13cba23e61@gmail.com>
On Thu, Jan 18, 2024 at 12:00:01PM +0300, Alexander Lakhin wrote:
> Thank you for working on this!
Yep, this one is obviously wrong so I have applied and backpatched the
fix for tablecmds.c.
> (Maybe it's possible to slightly modify an existing hierarchy with tables
> a, b, c in inherit.sql for the purpose of the check added.)
I was wondering about that, but decided to keep a separate test as
suggested as the other tests with inheritance are already tightly
linked to their own assumptions, mostly with renames and constraints.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: michael@paquier.xyz, exclusion@gmail.com, tndrwang@gmail.com, guofenglinux@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18297: Error when adding a column to a parent table with complex inheritance
In-Reply-To: <ZbCqZRvFu2iWHvo4@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox