pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Tender Wang <tndrwang@gmail.com>
Cc: Yongtao Huang <yongtaoh2022@gmail.com>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18310: Some SQL commands fail to process duplicate objects with error: tuple already updated by self
Date: Tue, 30 Jan 2024 10:14:58 +0900
Message-ID: <ZbhNktmvYQXQRAob@paquier.xyz> (raw)
In-Reply-To: <CAHewXN=-_by73hrquioKhG_N_-CB2HYhP3JZ329DT0sPnTEHww@mail.gmail.com>
References: <18310-1eb233c5908189c8@postgresql.org>
	<ZbMeI3EyyDlP-Agv@paquier.xyz>
	<CAHewXN=hBb4=Gr-QHiH95Q8XvLxwTRHLDwR4XmGV5PMU4PgNWQ@mail.gmail.com>
	<ZbMp3H9oVvubWkR5@paquier.xyz>
	<CAHewXNnaT6JM1wDR=ZxTiiRkgR+u_2Jd-AF-NiCCQVRL5ysX+A@mail.gmail.com>
	<CAHewXNk5yeUo2XPaqTYSfbkKhEBfKd4VYa7NHv2MzV-mJ9ULpA@mail.gmail.com>
	<CAOe1Go1N1XHYMXOq6+0=Awcpngmc9ei+3Jou2Om6o=giW+3pvw@mail.gmail.com>
	<ZbbgvVe_xbi-1U6n@paquier.xyz>
	<CAHewXN=-_by73hrquioKhG_N_-CB2HYhP3JZ329DT0sPnTEHww@mail.gmail.com>

On Mon, Jan 29, 2024 at 11:27:15AM +0800, Tender Wang wrote:
> Michael Paquier <michael@paquier.xyz> 于2024年1月29日周一 07:18写道：
>> Yes, incorrect indentation is something I have noticed in the previous
>> patches you have sent to the lists: all the new lines have an
>> incorrect indentation.  See here, where it is mentioned that the code
>> base uses 4 column tab spacing with tabs preserved:
>> https://www.postgresql.org/docs/devel/source-format.html
>>
>> FWIW, I am OK for simple patches, but this is going to make reviews
>> harder when it comes to read more complicated patches that touch more
>> code paths.
>>
> 
>  Sorry, my mistake.  Thanks for reminding.  Yongtao has help me fix the
> indentation issue in his  patch,
>  and I don't have new code to add.

The latest version posted on [1] was still not right.  I got a lot of
complaints from a simple `git diff --check`.  I am just looking at the
patch, no need to send something else.

[1]: https://www.postgresql.org/message-id/CAHewXNk5yeUo2XPaqTYSfbkKhEBfKd4VYa7NHv2MzV-mJ9ULpA@mail.gmail...
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (20+ messages)  latest in thread

Message-ID: <ZbhNktmvYQXQRAob@paquier.xyz>
Permalink:  ../ZbhNktmvYQXQRAob@paquier.xyz/
Also on:    postgresql.org/message-id/ZbhNktmvYQXQRAob@paquier.xyz

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: michael@paquier.xyz, tndrwang@gmail.com, yongtaoh2022@gmail.com, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #18310: Some SQL commands fail to process duplicate objects with error: tuple already updated by self
  In-Reply-To: <ZbhNktmvYQXQRAob@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox