From: Michael Paquier <michael@paquier.xyz>
To: Floris Van Nee <florisvannee@optiver.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: exclusion@gmail.com <exclusion@gmail.com>
Cc: pgsql-bugs@lists.postgresql.org <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #17947: Combination of replslots pgstat issues causes error/assertion failure
Date: Thu, 6 Jun 2024 08:51:10 +0900
Message-ID: <ZmD57ld6KIhJ4Pmi@paquier.xyz> (raw)
In-Reply-To: <a3de68e3a48c4a55a3f6f64d87486ffd@Optiver.com>
References: <17947-b9554521ad963c9c@postgresql.org>
<20230601.084245.1524588196504400333.horikyota.ntt@gmail.com>
<20240505183741.5tefii3razzefvtc@awork3.anarazel.de>
<dd4c68beba5c40c5a7946569d450ec59@Optiver.com>
<Zl6lQ_K0-QOfqUS4@paquier.xyz>
<a3de68e3a48c4a55a3f6f64d87486ffd@Optiver.com>
On Wed, Jun 05, 2024 at 10:24:43AM +0000, Floris Van Nee wrote:
> I noticed it but wasn't sure if it was necessary here due to the exceptional case here.
> It raises ereport error right after and can only reach this if the entry was created
> In the call to pgstat_prep_pending_entry before it, so it seems unlikely another
> backend holds a ref to it. I might be wrong though.
It does not prevent addressing the original issue, so pushed down to
15 after running concurrent tests for a few extra hours.
>> Attached is an updated patch with refined comments at the top of ?
>> pgstat_drop_entry(), to be applied to 15~.
>
> Thanks for testing the patch. Updated patch looks good to me.
I'll try to look at this one separately.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: michael@paquier.xyz, florisvannee@optiver.com, andres@anarazel.de, horikyota.ntt@gmail.com, exclusion@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17947: Combination of replslots pgstat issues causes error/assertion failure
In-Reply-To: <ZmD57ld6KIhJ4Pmi@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox