From: Floris Van Nee <florisvannee@Optiver.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Andres Freund <andres@anarazel.de>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: exclusion@gmail.com <exclusion@gmail.com>
Cc: pgsql-bugs@lists.postgresql.org <pgsql-bugs@lists.postgresql.org>
Subject: RE: BUG #17947: Combination of replslots pgstat issues causes error/assertion failure
Date: Wed, 5 Jun 2024 10:24:43 +0000
Message-ID: <a3de68e3a48c4a55a3f6f64d87486ffd@Optiver.com> (raw)
In-Reply-To: <Zl6lQ_K0-QOfqUS4@paquier.xyz>
References: <17947-b9554521ad963c9c@postgresql.org>
<20230601.084245.1524588196504400333.horikyota.ntt@gmail.com>
<20240505183741.5tefii3razzefvtc@awork3.anarazel.de>
<dd4c68beba5c40c5a7946569d450ec59@Optiver.com>
<Zl6lQ_K0-QOfqUS4@paquier.xyz>
>
> Note an extra edge case in pgstat_init_function_usage(), which should do
> the same, I guess?
>
I noticed it but wasn't sure if it was necessary here due to the exceptional case here.
It raises ereport error right after and can only reach this if the entry was created
In the call to pgstat_prep_pending_entry before it, so it seems unlikely another
backend holds a ref to it. I might be wrong though.
> Attached is an updated patch with refined comments at the top of ?
> pgstat_drop_entry(), to be applied to 15~.
Thanks for testing the patch. Updated patch looks good to me.
-Floris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: florisvannee@Optiver.com, michael@paquier.xyz, andres@anarazel.de, horikyota.ntt@gmail.com, exclusion@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: RE: BUG #17947: Combination of replslots pgstat issues causes error/assertion failure
In-Reply-To: <a3de68e3a48c4a55a3f6f64d87486ffd@Optiver.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox