From: Michael Paquier <michael@paquier.xyz>
To: Dean Rasheed <dean.a.rasheed@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: y@lll.gd
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18986: SIGSEGV in nodeModifyTable.c during Parallel Execution
Date: Thu, 17 Jul 2025 14:44:53 +0900
Message-ID: <aHiN1aldYZfbAvMO@paquier.xyz> (raw)
In-Reply-To: <CAEZATCWZahtK-OT5fa2=8b=+BUuDtsspkvur4x8WkjgHbxJxkw@mail.gmail.com>
References: <18986-e7a8aac3d339fa47@postgresql.org>
<937261.1752603233@sss.pgh.pa.us>
<aHbt_HkrM3TTH61j@paquier.xyz>
<CAEZATCUj7u_9MTDYZ7hzaf4uf1WrJ+fA3_M4dQKRvua0nP8sMg@mail.gmail.com>
<CAEZATCUahLe8Lvi7XHV6Eo=Tg46iJ2Rmfw0k6AH5GQbfOjENHQ@mail.gmail.com>
<aHeDl-0OuIA-MJtt@paquier.xyz>
<CAEZATCWZahtK-OT5fa2=8b=+BUuDtsspkvur4x8WkjgHbxJxkw@mail.gmail.com>
On Wed, Jul 16, 2025 at 02:05:06PM +0100, Dean Rasheed wrote:
> I decided to do this by adding an extra "is_merge_update" boolean
> parameter, rather than passing the commandType because that looked
> slightly neater. It was also necessary to update
> ExecBRDeleteTriggers(), since otherwise a concurrent MERGE DELETE
> could do the wrong thing (execute the wrong action, rather than
> seg-faulting). That was picked up by an existing isolation test case
> added by 9321c79, so no need for more tests.
Looks sensible here, for the HEAD and v17 flavors.
> I haven't tested this against the OP's reproducer.
Except waiting for the OP to actually test the fix, I'm not sure if
there is much that we can do. Anyway, the stack that one gets with
the isolation test is very close to what the OP has reported, so I'm
ready to bet a coffee that you have been able to narrow this one down.
I have also raised an issue to timescale to make them aware of the
issue. I have no idea if this is an issue for them, just acting as a
reporter:
https://github.com/timescale/timescaledb/issues/8392
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../aHiN1aldYZfbAvMO@paquier.xyz/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: michael@paquier.xyz, dean.a.rasheed@gmail.com, tgl@sss.pgh.pa.us, y@lll.gd, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18986: SIGSEGV in nodeModifyTable.c during Parallel Execution
In-Reply-To: <aHiN1aldYZfbAvMO@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox