pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: ewaldo@healthetechs.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16342: CREATE TABLE LIKE INCLUDING GENERATED column order issue
Date: Thu, 9 Apr 2020 16:48:29 +0200
Message-ID: <dff50573-9092-4ad0-8fb6-a1f01e736f13@2ndquadrant.com> (raw)
In-Reply-To: <10837.1586100396@sss.pgh.pa.us>
References: <16342-50008a509308f4ca@postgresql.org>
	<db920c8a-063e-a320-c5e8-096f0eedc154@2ndquadrant.com>
	<10837.1586100396@sss.pgh.pa.us>

On 2020-04-05 17:26, Tom Lane wrote:
> Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
>> Confirmed.  Attached is a patch to fix it.  Thanks for the report!
> 
> LGTM.  Perhaps extend the comment block just above, adding something
> like "We must fill the attmap now so it can be used to process
> GENERATED default expressions in the per-column loop."

Committed with that.

Ethan, this will be in the next minor release of PostgreSQL 12.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services





view thread (5+ messages)  latest in thread

Message-ID: <dff50573-9092-4ad0-8fb6-a1f01e736f13@2ndquadrant.com>
Permalink:  ../dff50573-9092-4ad0-8fb6-a1f01e736f13@2ndquadrant.com/
Also on:    postgresql.org/message-id/dff50573-9092-4ad0-8fb6-a1f01e736f13@2ndquadrant.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-bugs@postgresql.org
  Cc: peter.eisentraut@2ndquadrant.com, tgl@sss.pgh.pa.us, ewaldo@healthetechs.com
  Subject: Re: BUG #16342: CREATE TABLE LIKE INCLUDING GENERATED column order issue
  In-Reply-To: <dff50573-9092-4ad0-8fb6-a1f01e736f13@2ndquadrant.com>
  References: <16342-50008a509308f4ca@postgresql.org> <db920c8a-063e-a320-c5e8-096f0eedc154@2ndquadrant.com> <10837.1586100396@sss.pgh.pa.us> <dff50573-9092-4ad0-8fb6-a1f01e736f13@2ndquadrant.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox