pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Alexander Lakhin <exclusion@gmail.com>
To: Joe Conway <mail@joeconway.com>
To: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16466: Valgrind detects an invalid read in dblink_open() with a cursor inside a transaction
Date: Thu, 28 May 2020 00:00:00 +0300
Message-ID: <fb147109-0512-8dc7-5e29-7b4b89ed246e@gmail.com> (raw)
In-Reply-To: <9bd0744f-5f04-c778-c5b3-809efe9c30c7@joeconway.com>
References: <16466-09cfa4a5a0e72cce@postgresql.org>
	<9bd0744f-5f04-c778-c5b3-809efe9c30c7@joeconway.com>

Hello Joe,

27.05.2020 22:58, Joe Conway wrote:
> Hmmm, looks like a couple of the members of rconn are left uninitialized.
>
> When dblink_open() is called *without* an outer transaction it handles the
> initialization for us, but *with* an outer transaction it does not :-(
>
> I think the attached fixes it.
Yes, your patch makes valgrind silent.
Thanks!

Best regards,
Alexander





view thread (4+ messages)  latest in thread

Message-ID: <fb147109-0512-8dc7-5e29-7b4b89ed246e@gmail.com>
Permalink:  ../fb147109-0512-8dc7-5e29-7b4b89ed246e@gmail.com/
Also on:    postgresql.org/message-id/fb147109-0512-8dc7-5e29-7b4b89ed246e@gmail.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: exclusion@gmail.com, mail@joeconway.com, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #16466: Valgrind detects an invalid read in dblink_open() with a cursor inside a transaction
  In-Reply-To: <fb147109-0512-8dc7-5e29-7b4b89ed246e@gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox