pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andrew Dunstan <andrew@dunslane.net>
To: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Allow building with MSVC and Strawberry perl
Date: Fri, 25 Nov 2022 17:11:51 -0500
Message-ID: <02b5e6c8-a062-94f0-1add-db1fd1db5f0b@dunslane.net> (raw)
In-Reply-To: <E1oyfT5-000o2o-C9@gemulon.postgresql.org>
References: <E1oyfT5-000o2o-C9@gemulon.postgresql.org>


On 2022-11-25 Fr 15:38, Andrew Dunstan wrote:
> Allow building with MSVC and Strawberry perl
>
> Strawberry uses __builtin_expect which Visual C doesn't have. For this
> case define it as a noop. Solution taken from vim sources.


Argh! drongo doesn't seem to like this. I thought I'd tested it.

A little further googling suggests that instead of


#define __builtin_expect(expr, val) (expr)


we should probably have something like


#define __builtin_expect(expr, val) ((expr) == (val))


I'll try that.


cheers


andrew


--
Andrew Dunstan
EDB: https://www.enterprisedb.com






view thread (11+ messages)  latest in thread

Message-ID: <02b5e6c8-a062-94f0-1add-db1fd1db5f0b@dunslane.net>
Permalink:  ../02b5e6c8-a062-94f0-1add-db1fd1db5f0b@dunslane.net/
Also on:    postgresql.org/message-id/02b5e6c8-a062-94f0-1add-db1fd1db5f0b@dunslane.net

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: andrew@dunslane.net
  Subject: Re: pgsql: Allow building with MSVC and Strawberry perl
  In-Reply-To: <02b5e6c8-a062-94f0-1add-db1fd1db5f0b@dunslane.net>
  References: <E1oyfT5-000o2o-C9@gemulon.postgresql.org> <02b5e6c8-a062-94f0-1add-db1fd1db5f0b@dunslane.net>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox