pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andres Freund <andres@anarazel.de>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Allow building with MSVC and Strawberry perl
Date: Fri, 25 Nov 2022 16:22:15 -0800
Message-ID: <20221126002215.7xcmiza3jexpkemw@awork3.anarazel.de> (raw)
In-Reply-To: <a618e87b-2bdd-f00a-20f6-9f7e0651aa72@dunslane.net>
References: <E1oyfT5-000o2o-C9@gemulon.postgresql.org>
	<02b5e6c8-a062-94f0-1add-db1fd1db5f0b@dunslane.net>
	<20221125233331.dh4yrd76a3mnwj4s@awork3.anarazel.de>
	<20221125234813.25iiq5snxejebdak@awork3.anarazel.de>
	<a618e87b-2bdd-f00a-20f6-9f7e0651aa72@dunslane.net>

Hi,

On 2022-11-25 18:56:02 -0500, Andrew Dunstan wrote:
> On 2022-11-25 Fr 18:48, Andres Freund wrote:
> > On 2022-11-25 15:33:31 -0800, Andres Freund wrote:
> >> FWIW a meson build with msvc 2019 and strawberry perl 5.32 builds fine with
> >> #define __builtin_expect(expr, val) (expr)
> > And it does so with src/tools/msvc as well.  I think we might need a
> > preprocessed plperl.c from drongo to analyze this further.
> >
> > There might be some unrelated under-specified build issues, I get weird errors
> > if I start by building plperl.vcxproj, without first having built
> > postgres.vcxproj. But ...
> >
> 
> 
> Yeah, drongo builds fine too.

Oh - I just looked at HEAD, where it fails in the 'make' stage on the BF. But
I now see the PLCheck-C failures in the older branches.


> It's the handshake thing that's the current issue. I'll see if forcing
> -DNO_THREAD_SAFE_LOCALE works.

With it tests do pass for me with meson + msvc + perl 5.32.

Greetings,

Andres Freund





view thread (11+ messages)

Message-ID: <20221126002215.7xcmiza3jexpkemw@awork3.anarazel.de>
Permalink:  ../20221126002215.7xcmiza3jexpkemw@awork3.anarazel.de/
Also on:    postgresql.org/message-id/20221126002215.7xcmiza3jexpkemw@awork3.anarazel.de

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: andres@anarazel.de, andrew@dunslane.net
  Subject: Re: pgsql: Allow building with MSVC and Strawberry perl
  In-Reply-To: <20221126002215.7xcmiza3jexpkemw@awork3.anarazel.de>
  References: <E1oyfT5-000o2o-C9@gemulon.postgresql.org> <02b5e6c8-a062-94f0-1add-db1fd1db5f0b@dunslane.net> <20221125233331.dh4yrd76a3mnwj4s@awork3.anarazel.de> <20221125234813.25iiq5snxejebdak@awork3.anarazel.de> <a618e87b-2bdd-f00a-20f6-9f7e0651aa72@dunslane.net> <20221126002215.7xcmiza3jexpkemw@awork3.anarazel.de>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox